Skip to content

Use weights_only for load #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2023
Merged

Use weights_only for load #5

merged 1 commit into from
Nov 30, 2023

Conversation

@kit1980
Copy link
Contributor

@kit1980 kit1980 commented Nov 30, 2023 •
edited
Loading

torch.load without weights_only is unsafe.
We probably want to set it to follow best practices as this code will likely be reused.

If weights_only=True doesn't work here, then explicit weights_only=False should be used.

Found with https://github.com/pytorch-labs/torchfix/

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 30, 2023
@kit1980 kit1980 requested a review from Chillee November 30, 2023 23:07
Chillee
Chillee approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@Chillee Chillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Chillee Chillee merged commit 790d30c into main Nov 30, 2023
@kit1980 kit1980 deleted the sdym/weights-only branch December 1, 2023 00:04
mostafaelhoushi added a commit that referenced this pull request Sep 17, 2024
@mostafaelhoushi
Merge pull request #5 from fairinternal/changes-for-bigcode2
bfc1d37 
More Changes for BigCode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Chillee Chillee Chillee approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kit1980 @Chillee @facebook-github-bot