fix mast job trait #1569
Closed
fix mast job trait #1569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@colin2328 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84844137. |
colin2328
force-pushed
the
export-D84844137
branch
from
4ca4343 to
e6bb91d
Compare
colin2328
added a commit
to colin2328/monarch-1
that referenced
this pull request
Oct 16, 2025
Summary: P1995406113 fix MastJob to use dimensionless 2nd dim (TODO fix) Differential Revision: D84844137
colin2328
force-pushed
the
export-D84844137
branch
from
e6bb91d to
6ed141c
Compare
colin2328
added a commit
to colin2328/monarch-1
that referenced
this pull request
Oct 16, 2025
Summary: P1995406113 allow process allocator to take 1 dimension only Differential Revision: D84844137
colin2328
added a commit
to colin2328/monarch-1
that referenced
this pull request
Oct 16, 2025
Summary: P1995406113 allow process allocator to take 1 dimension only Differential Revision: D84844137
colin2328
force-pushed
the
export-D84844137
branch
from
6ed141c to
7336cac
Compare
colin2328
added a commit
to colin2328/monarch-1
that referenced
this pull request
Oct 16, 2025
Summary: P1995406113 allow process allocator to take 1 dimension only Differential Revision: D84844137
colin2328
force-pushed
the
export-D84844137
branch
2 times, most recently
from
1539ac1 to
0f51192
Compare
colin2328
added a commit
to colin2328/monarch-1
that referenced
this pull request
Oct 21, 2025
Summary: P1995406113 allow process allocator to take 1 dimension only Differential Revision: D84844137
colin2328
added a commit
to colin2328/monarch-1
that referenced
this pull request
Oct 21, 2025
Summary: P1995406113 allow process allocator to take 1 dimension only Differential Revision: D84844137
colin2328
force-pushed
the
export-D84844137
branch
from
0f51192 to
6f3bf5f
Compare
colin2328
added a commit
to colin2328/monarch-1
that referenced
this pull request
Oct 21, 2025
Summary: P1995406113 allow process allocator to take 1 dimension only Differential Revision: D84844137
colin2328
force-pushed
the
export-D84844137
branch
from
6f3bf5f to
6470847
Compare
colin2328
added a commit
to colin2328/monarch-1
that referenced
this pull request
Oct 21, 2025
Summary: P1995406113 allow process allocator to take 1 dimension only Differential Revision: D84844137
colin2328
force-pushed
the
export-D84844137
branch
from
6470847 to
b221160
Compare
colin2328
added a commit
to colin2328/monarch-1
that referenced
this pull request
Oct 21, 2025
Summary: P1995406113 allow process allocator to take 1 dimension only updated based on mariusae feedback to use "So we should just make that explicit, and expose two different MAST allocators (the only difference is how they interpret the extent). But at least then we have clear and well-defined behavior." Differential Revision: D84844137
colin2328
force-pushed
the
export-D84844137
branch
from
b221160 to
5ff6a07
Compare
colin2328
force-pushed
the
export-D84844137
branch
from
5ff6a07 to
2ef8c5c
Compare
colin2328
added a commit
to colin2328/monarch-1
that referenced
this pull request
Nov 6, 2025
Summary: P1995406113 allow process allocator to take 1 dimension only updated based on mariusae feedback to use "So we should just make that explicit, and expose two different MAST allocators (the only difference is how they interpret the extent). But at least then we have clear and well-defined behavior." Reviewed By: mariusae Differential Revision: D84844137
colin2328
added a commit
to colin2328/monarch-1
that referenced
this pull request
Nov 7, 2025
Summary: P1995406113 allow process allocator to take 1 dimension only updated based on mariusae feedback to use "So we should just make that explicit, and expose two different MAST allocators (the only difference is how they interpret the extent). But at least then we have clear and well-defined behavior." Reviewed By: mariusae Differential Revision: D84844137
colin2328
force-pushed
the
export-D84844137
branch
from
2ef8c5c to
680111d
Compare
colin2328
added a commit
to colin2328/monarch-1
that referenced
this pull request
Nov 7, 2025
Summary: P1995406113 allow process allocator to take 1 dimension only updated based on mariusae feedback to use "So we should just make that explicit, and expose two different MAST allocators (the only difference is how they interpret the extent). But at least then we have clear and well-defined behavior." Reviewed By: mariusae Differential Revision: D84844137
colin2328
force-pushed
the
export-D84844137
branch
from
680111d to
7670ef6
Compare
colin2328
added a commit
to colin2328/monarch-1
that referenced
this pull request
Nov 7, 2025
Summary: P1995406113 allow process allocator to take 1 dimension only updated based on mariusae feedback to use "So we should just make that explicit, and expose two different MAST allocators (the only difference is how they interpret the extent). But at least then we have clear and well-defined behavior." Reviewed By: mariusae Differential Revision: D84844137
colin2328
force-pushed
the
export-D84844137
branch
from
7670ef6 to
c821586
Compare
Summary: P1995406113 allow process allocator to take 1 dimension only updated based on mariusae feedback to use "So we should just make that explicit, and expose two different MAST allocators (the only difference is how they interpret the extent). But at least then we have clear and well-defined behavior." Reviewed By: mariusae Differential Revision: D84844137
colin2328
force-pushed
the
export-D84844137
branch
from
c821586 to
ed31e71
Compare
|
This pull request has been merged in 4366269. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
P1995406113
fix MastJob to use dimensionless 2nd dim (TODO fix)
Reviewed By: samlurye
Differential Revision: D84844137