[monarch] Fix race condition during ProcMesh stop #1662
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Await `ProcMesh._proc_mesh` before flushing logging manager so that we can be sure the logging client has been spawned and avoid throwing an assertion error. Differential Revision: [D85472096](https://our.internmc.facebook.com/intern/diff/D85472096/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D85472096/)! [ghstack-poisoned]
samlurye
added a commit
that referenced
this pull request
Oct 24, 2025
Await `ProcMesh._proc_mesh` before flushing logging manager so that we can be sure the logging client has been spawned and avoid throwing an assertion error. Differential Revision: [D85472096](https://our.internmc.facebook.com/intern/diff/D85472096/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D85472096/)! ghstack-source-id: 318646781 Pull Request resolved: #1662
meta-cla
bot
added
the
CLA Signed
Await `ProcMesh._proc_mesh` before flushing logging manager so that we can be sure the logging client has been spawned and avoid throwing an assertion error. Differential Revision: [D85472096](https://our.internmc.facebook.com/intern/diff/D85472096/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D85472096/)! [ghstack-poisoned]
samlurye
added a commit
that referenced
this pull request
Oct 27, 2025
Pull Request resolved: #1662 Await `ProcMesh._proc_mesh` before flushing logging manager so that we can be sure the logging client has been spawned and avoid throwing an assertion error. ghstack-source-id: 318944284 @exported-using-ghexport Differential Revision: [D85472096](https://our.internmc.facebook.com/intern/diff/D85472096/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D85472096/)!
Await `ProcMesh._proc_mesh` before flushing logging manager so that we can be sure the logging client has been spawned and avoid throwing an assertion error. Differential Revision: [D85472096](https://our.internmc.facebook.com/intern/diff/D85472096/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D85472096/)! [ghstack-poisoned]
samlurye
added a commit
that referenced
this pull request
Oct 27, 2025
Pull Request resolved: #1662 Await `ProcMesh._proc_mesh` before flushing logging manager so that we can be sure the logging client has been spawned and avoid throwing an assertion error. ghstack-source-id: 318971110 @exported-using-ghexport Differential Revision: [D85472096](https://our.internmc.facebook.com/intern/diff/D85472096/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D85472096/)!
|
This pull request has been merged in c758e7a. |
AlirezaShamsoshoara
pushed a commit
to AlirezaShamsoshoara/monarch
that referenced
this pull request
Oct 30, 2025
Summary: Pull Request resolved: meta-pytorch#1662 Await `ProcMesh._proc_mesh` before flushing logging manager so that we can be sure the logging client has been spawned and avoid throwing an assertion error. ghstack-source-id: 318971110 exported-using-ghexport Reviewed By: amirafzali Differential Revision: D85472096 fbshipit-source-id: 29e2d2a77bfb36ff0c05c85436db351a747a7d11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Await
ProcMesh._proc_meshbefore flushing logging manager so that we can be sure the logging client has been spawned and avoid throwing an assertion error.Differential Revision: D85472096
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!