Add reason to channel::serve #1674
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We found this log not helpful when debugging S576170. But it causes log spew and makes it hard to find other useful logs. Downgrade to TRACE instead of deleting it just in case we might need it in the future debugging (at that time we can manually bump its level). Reviewed By: shayne-fletcher Differential Revision: D85533659
Summary: Two changes: 1. Include the timeout value in the log. 2. Include port id and message type name, or hash if not registered, in the undelivered message error. It it will look like the following in a returned message log: > metatls:twshared13737.02.gtn2.facebook.com:46155,service,agent[0]: actor failure: serving metatls:twshared13737.02.gtn2.facebook.com:46155,service,agent[0]: processing error: a message from metatls:twshared13737.02.gtn2.facebook.com:46155,service,agent[0] to metatls:twshared13736.02.gtn2.facebook.com:40835,mesh_root_client_proc,client[0][430914] was undeliverable and returned: Some(**"address not routable: port not bound in mailbox; port id: 430914; message type: unregistered type hash 16038717096654025819**; broken link: message was undeliverable") Reviewed By: shayne-fletcher Differential Revision: D85537948
Summary: We need to have a way to associate the channel address to why it was served. This diff adds a reason parameter to `channel::serve` and log it along with the address. We probably do not need this diff in the future if we include "reason" or something similar in the channel's name directly. But before that, this diff is required otherwise we cannot debug channel errors in many cases. Reviewed By: shayne-fletcher Differential Revision: D85529357
meta-cla
bot
added
the
CLA Signed
|
This pull request has been merged in 1ee6502. |
AlirezaShamsoshoara
pushed a commit
to AlirezaShamsoshoara/monarch
that referenced
this pull request
Oct 30, 2025
Summary: Pull Request resolved: meta-pytorch#1674 We need to have a way to associate the channel address to why it was served. This diff adds a reason parameter to `channel::serve` and log it along with the address. We probably do not need this diff in the future if we include "reason" or something similar in the channel's name directly. But before that, this diff is required otherwise we cannot debug channel errors in many cases. Reviewed By: shayne-fletcher Differential Revision: D85529357 fbshipit-source-id: d75146766ff93834d5781ee67833084ca5932854
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We need to have a way to associate the channel address to why it was served. This diff adds a reason parameter to
channel::serveand log it along with the address.We probably do not need this diff in the future if we include "reason" or something similar in the channel's name directly. But before that, this diff is required otherwise we cannot debug channel errors in many cases.
Reviewed By: shayne-fletcher
Differential Revision: D85529357