Change ActorStatus to Stopping and Stopped only once #1889
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dulinriley has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87082404. |
meta-cla
bot
added
the
CLA Signed
dulinriley
added a commit
to dulinriley/monarch
that referenced
this pull request
Nov 14, 2025
Summary: Minor change: before the "Instance::run" and "Instance::run_actor_tree" would both try to change the ActorStatus to Stopping and Stopped. Going back and forth from a terminal state could introduce timing errors on status watchers, which watch for Stopped or Failed. Just do this once in run_actor_tree once all child actors are stopped and cleanup has run. Added an assert to `change_status` to ensure this is the case. Reviewed By: mariusae Differential Revision: D87082404
dulinriley
force-pushed
the
export-D87082404
branch
2 times, most recently
from
0a63c3d to
f2329e6
Compare
dulinriley
added a commit
to dulinriley/monarch
that referenced
this pull request
Nov 14, 2025
Summary: Minor change: before the "Instance::run" and "Instance::run_actor_tree" would both try to change the ActorStatus to Stopping and Stopped. Going back and forth from a terminal state could introduce timing errors on status watchers, which watch for Stopped or Failed. Just do this once in run_actor_tree once all child actors are stopped and cleanup has run. Added an assert to `change_status` to ensure this is the case. Differential Revision: D87082404
dulinriley
force-pushed
the
export-D87082404
branch
from
f2329e6 to
9969169
Compare
dulinriley
added a commit
to dulinriley/monarch
that referenced
this pull request
Nov 17, 2025
…ytorch#1889) Summary: Before the "Instance::run" and "Instance::run_actor_tree" would both try to change the ActorStatus to Stopping and Stopped. Going back and forth from a terminal state could introduce timing errors on status watchers, which watch for Stopped or Failed. Just do this once in run_actor_tree once all child actors are stopped and cleanup has run. Added an assert to `change_status` to ensure this is the case. Also disallow changing from Stopped -> Failed. Actors should only have a single terminal state. Reviewed By: mariusae Differential Revision: D87082404
dulinriley
force-pushed
the
export-D87082404
branch
from
9969169 to
4d2a418
Compare
dulinriley
added a commit
to dulinriley/monarch
that referenced
this pull request
Nov 18, 2025
…ytorch#1889) Summary: Before the "Instance::run" and "Instance::run_actor_tree" would both try to change the ActorStatus to Stopping and Stopped. Going back and forth from a terminal state could introduce timing errors on status watchers, which watch for Stopped or Failed. Just do this once in run_actor_tree once all child actors are stopped and cleanup has run. Added an assert to `change_status` to ensure this is the case. Also disallow changing from Stopped -> Failed. Actors should only have a single terminal state. Reviewed By: mariusae Differential Revision: D87082404
…ytorch#1889) Summary: Before the "Instance::run" and "Instance::run_actor_tree" would both try to change the ActorStatus to Stopping and Stopped. Going back and forth from a terminal state could introduce timing errors on status watchers, which watch for Stopped or Failed. Just do this once in run_actor_tree once all child actors are stopped and cleanup has run. Added an assert to `change_status` to ensure this is the case. Also disallow changing from Stopped -> Failed. Actors should only have a single terminal state. Reviewed By: mariusae Differential Revision: D87082404
dulinriley
force-pushed
the
export-D87082404
branch
from
4d2a418 to
c14c539
Compare
|
This pull request has been merged in 2760b20. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Minor change: before the "Instance::run" and "Instance::run_actor_tree" would both
try to change the ActorStatus to Stopping and Stopped. Going back and forth from a terminal
state could introduce timing errors on status watchers, which watch for Stopped or Failed.
Just do this once in run_actor_tree once all child actors are stopped and cleanup has run.
Reviewed By: mariusae
Differential Revision: D87082404