propagate display name for process failures #1911
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like this now:
```
The actor <root>.<tests.test_supervision_hierarchy.Nest top> and all its descendants have failed.
This occurred because the actor <root>.<tests.test_supervision_hierarchy.Nest top>.<tests.test_supervision_hierarchy.Lambda nested{'a_dim': 0/1}> was running on a process which failed.
The error was:
process failure: Killed(sig=9)
```
Kinda janky because supervision code is messy. When we clean up supervision code, we should make sure the owning actor knows the friendly names of all of its children (e.g. has a map from actor/proc id to their fully qualified display names). A parent always knows what the name will be before it spawns it.
Differential Revision: [D87284093](https://our.internmc.facebook.com/intern/diff/D87284093/)
**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87284093/)!
[ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Nov 18, 2025
Looks like this now:
```
The actor <root>.<tests.test_supervision_hierarchy.Nest top> and all its descendants have failed.
This occurred because the actor <root>.<tests.test_supervision_hierarchy.Nest top>.<tests.test_supervision_hierarchy.Lambda nested{'a_dim': 0/1}> was running on a process which failed.
The error was:
process failure: Killed(sig=9)
```
Kinda janky because supervision code is messy. When we clean up supervision code, we should make sure the owning actor knows the friendly names of all of its children (e.g. has a map from actor/proc id to their fully qualified display names). A parent always knows what the name will be before it spawns it.
Differential Revision: [D87284093](https://our.internmc.facebook.com/intern/diff/D87284093/)
**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87284093/)!
ghstack-source-id: 323985996
Pull Request resolved: #1911
meta-cla
bot
added
the
CLA Signed
Looks like this now:
```
The actor <root>.<tests.test_supervision_hierarchy.Nest top> and all its descendants have failed.
This occurred because the actor <root>.<tests.test_supervision_hierarchy.Nest top>.<tests.test_supervision_hierarchy.Lambda nested{'a_dim': 0/1}> was running on a process which failed.
The error was:
process failure: Killed(sig=9)
```
Kinda janky because supervision code is messy. When we clean up supervision code, we should make sure the owning actor knows the friendly names of all of its children (e.g. has a map from actor/proc id to their fully qualified display names). A parent always knows what the name will be before it spawns it.
Differential Revision: [D87284093](https://our.internmc.facebook.com/intern/diff/D87284093/)
**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87284093/)!
[ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Nov 18, 2025
Pull Request resolved: #1911 Looks like this now: ``` The actor <root>.<tests.test_supervision_hierarchy.Nest top> and all its descendants have failed. This occurred because the actor <root>.<tests.test_supervision_hierarchy.Nest top>.<tests.test_supervision_hierarchy.Lambda nested{'a_dim': 0/1}> was running on a process which failed. The error was: process failure: Killed(sig=9) ``` Kinda janky because supervision code is messy. When we clean up supervision code, we should make sure the owning actor knows the friendly names of all of its children (e.g. has a map from actor/proc id to their fully qualified display names). A parent always knows what the name will be before it spawns it. ghstack-source-id: 324165921 @exported-using-ghexport Differential Revision: [D87284093](https://our.internmc.facebook.com/intern/diff/D87284093/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87284093/)!
|
This pull request has been merged in 6757d53. |
This was referenced Nov 19, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Looks like this now:
Kinda janky because supervision code is messy. When we clean up supervision code, we should make sure the owning actor knows the friendly names of all of its children (e.g. has a map from actor/proc id to their fully qualified display names). A parent always knows what the name will be before it spawns it.
Differential Revision: D87284093
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!