[hyperactor] make all variants of spawn sync
#1968
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building on the previous diff, separating out remote from local instantiation, this diff implements synchronous spawns throughout. This means we can always spawn an actor in a nonblocking way, regardless of context. Spawns should also become infallible, instead relying on supervision to handle errors. Differential Revision: [D87608082](https://our.internmc.facebook.com/intern/diff/D87608082/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87608082/)! [ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Nov 21, 2025
Building on the previous diff, separating out remote from local instantiation, this diff implements synchronous spawns throughout. This means we can always spawn an actor in a nonblocking way, regardless of context. Spawns should also become infallible, instead relying on supervision to handle errors. Differential Revision: [D87608082](https://our.internmc.facebook.com/intern/diff/D87608082/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87608082/)! ghstack-source-id: 324888978 Pull Request resolved: #1968
meta-cla
bot
added
the
CLA Signed
Building on the previous diff, separating out remote from local instantiation, this diff implements synchronous spawns throughout. This means we can always spawn an actor in a nonblocking way, regardless of context. Spawns should also become infallible, instead relying on supervision to handle errors. Differential Revision: [D87608082](https://our.internmc.facebook.com/intern/diff/D87608082/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87608082/)! [ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Nov 21, 2025
Pull Request resolved: #1968 Building on the previous diff, separating out remote from local instantiation, this diff implements synchronous spawns throughout. This means we can always spawn an actor in a nonblocking way, regardless of context. Spawns should also become infallible, instead relying on supervision to handle errors. Differential Revision: [D87608082](https://our.internmc.facebook.com/intern/diff/D87608082/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87608082/)! ghstack-source-id: 324989594
Building on the previous diff, separating out remote from local instantiation, this diff implements synchronous spawns throughout. This means we can always spawn an actor in a nonblocking way, regardless of context. Spawns should also become infallible, instead relying on supervision to handle errors. Differential Revision: [D87608082](https://our.internmc.facebook.com/intern/diff/D87608082/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87608082/)! [ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Nov 21, 2025
Pull Request resolved: #1968 Building on the previous diff, separating out remote from local instantiation, this diff implements synchronous spawns throughout. This means we can always spawn an actor in a nonblocking way, regardless of context. Spawns should also become infallible, instead relying on supervision to handle errors. ghstack-source-id: 324991672 Differential Revision: [D87608082](https://our.internmc.facebook.com/intern/diff/D87608082/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87608082/)!
Building on the previous diff, separating out remote from local instantiation, this diff implements synchronous spawns throughout. This means we can always spawn an actor in a nonblocking way, regardless of context. Spawns should also become infallible, instead relying on supervision to handle errors. Differential Revision: [D87608082](https://our.internmc.facebook.com/intern/diff/D87608082/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87608082/)! [ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Nov 21, 2025
Pull Request resolved: #1968 Building on the previous diff, separating out remote from local instantiation, this diff implements synchronous spawns throughout. This means we can always spawn an actor in a nonblocking way, regardless of context. Spawns should also become infallible, instead relying on supervision to handle errors. ghstack-source-id: 325005475 Differential Revision: [D87608082](https://our.internmc.facebook.com/intern/diff/D87608082/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87608082/)!
Building on the previous diff, separating out remote from local instantiation, this diff implements synchronous spawns throughout. This means we can always spawn an actor in a nonblocking way, regardless of context. Spawns should also become infallible, instead relying on supervision to handle errors. Differential Revision: [D87608082](https://our.internmc.facebook.com/intern/diff/D87608082/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87608082/)! [ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Nov 21, 2025
Pull Request resolved: #1968 Building on the previous diff, separating out remote from local instantiation, this diff implements synchronous spawns throughout. This means we can always spawn an actor in a nonblocking way, regardless of context. Spawns should also become infallible, instead relying on supervision to handle errors. ghstack-source-id: 325023201 Differential Revision: [D87608082](https://our.internmc.facebook.com/intern/diff/D87608082/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87608082/)!
Building on the previous diff, separating out remote from local instantiation, this diff implements synchronous spawns throughout. This means we can always spawn an actor in a nonblocking way, regardless of context. Spawns should also become infallible, instead relying on supervision to handle errors. Differential Revision: [D87608082](https://our.internmc.facebook.com/intern/diff/D87608082/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87608082/)! [ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Nov 21, 2025
Pull Request resolved: #1968 Building on the previous diff, separating out remote from local instantiation, this diff implements synchronous spawns throughout. This means we can always spawn an actor in a nonblocking way, regardless of context. Spawns should also become infallible, instead relying on supervision to handle errors. ghstack-source-id: 325032813 Differential Revision: [D87608082](https://our.internmc.facebook.com/intern/diff/D87608082/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87608082/)!
Building on the previous diff, separating out remote from local instantiation, this diff implements synchronous spawns throughout. This means we can always spawn an actor in a nonblocking way, regardless of context. Spawns should also become infallible, instead relying on supervision to handle errors. Differential Revision: [D87608082](https://our.internmc.facebook.com/intern/diff/D87608082/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87608082/)! [ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Nov 24, 2025
Pull Request resolved: #1968 Building on the previous diff, separating out remote from local instantiation, this diff implements synchronous spawns throughout. This means we can always spawn an actor in a nonblocking way, regardless of context. Spawns should also become infallible, instead relying on supervision to handle errors. ghstack-source-id: 325278669 Differential Revision: [D87608082](https://our.internmc.facebook.com/intern/diff/D87608082/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87608082/)!
Building on the previous diff, separating out remote from local instantiation, this diff implements synchronous spawns throughout. This means we can always spawn an actor in a nonblocking way, regardless of context. Spawns should also become infallible, instead relying on supervision to handle errors. Differential Revision: [D87608082](https://our.internmc.facebook.com/intern/diff/D87608082/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87608082/)! [ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Nov 24, 2025
Pull Request resolved: #1968 Building on the previous diff, separating out remote from local instantiation, this diff implements synchronous spawns throughout. This means we can always spawn an actor in a nonblocking way, regardless of context. Spawns should also become infallible, instead relying on supervision to handle errors. ghstack-source-id: 325392617 Differential Revision: [D87608082](https://our.internmc.facebook.com/intern/diff/D87608082/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87608082/)!
Building on the previous diff, separating out remote from local instantiation, this diff implements synchronous spawns throughout. This means we can always spawn an actor in a nonblocking way, regardless of context. Spawns should also become infallible, instead relying on supervision to handle errors. Differential Revision: [D87608082](https://our.internmc.facebook.com/intern/diff/D87608082/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87608082/)! [ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Nov 24, 2025
Pull Request resolved: #1968 Building on the previous diff, separating out remote from local instantiation, this diff implements synchronous spawns throughout. This means we can always spawn an actor in a nonblocking way, regardless of context. Spawns should also become infallible, instead relying on supervision to handle errors. ghstack-source-id: 325451165 Differential Revision: [D87608082](https://our.internmc.facebook.com/intern/diff/D87608082/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87608082/)!
Building on the previous diff, separating out remote from local instantiation, this diff implements synchronous spawns throughout. This means we can always spawn an actor in a nonblocking way, regardless of context. Spawns should also become infallible, instead relying on supervision to handle errors. Differential Revision: [D87608082](https://our.internmc.facebook.com/intern/diff/D87608082/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87608082/)! [ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Nov 24, 2025
Pull Request resolved: #1968 Building on the previous diff, separating out remote from local instantiation, this diff implements synchronous spawns throughout. This means we can always spawn an actor in a nonblocking way, regardless of context. Spawns should also become infallible, instead relying on supervision to handle errors. ghstack-source-id: 325454691 Differential Revision: [D87608082](https://our.internmc.facebook.com/intern/diff/D87608082/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87608082/)!
Building on the previous diff, separating out remote from local instantiation, this diff implements synchronous spawns throughout. This means we can always spawn an actor in a nonblocking way, regardless of context. Spawns should also become infallible, instead relying on supervision to handle errors. Differential Revision: [D87608082](https://our.internmc.facebook.com/intern/diff/D87608082/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87608082/)! [ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Nov 24, 2025
Pull Request resolved: #1968 Building on the previous diff, separating out remote from local instantiation, this diff implements synchronous spawns throughout. This means we can always spawn an actor in a nonblocking way, regardless of context. Spawns should also become infallible, instead relying on supervision to handle errors. ghstack-source-id: 325462726 Differential Revision: [D87608082](https://our.internmc.facebook.com/intern/diff/D87608082/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87608082/)!
Building on the previous diff, separating out remote from local instantiation, this diff implements synchronous spawns throughout. This means we can always spawn an actor in a nonblocking way, regardless of context. Spawns should also become infallible, instead relying on supervision to handle errors. Differential Revision: [D87608082](https://our.internmc.facebook.com/intern/diff/D87608082/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87608082/)! [ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Nov 25, 2025
Pull Request resolved: #1968 Building on the previous diff, separating out remote from local instantiation, this diff implements synchronous spawns throughout. This means we can always spawn an actor in a nonblocking way, regardless of context. Spawns should also become infallible, instead relying on supervision to handle errors. ghstack-source-id: 325529060 Differential Revision: [D87608082](https://our.internmc.facebook.com/intern/diff/D87608082/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87608082/)!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
spawnsync #1968newfrom actor #1962Building on the previous diff, separating out remote from local instantiation, this diff implements synchronous spawns throughout. This means we can always spawn an actor in a nonblocking way, regardless of context.
Spawns should also become infallible, instead relying on supervision to handle errors.
Differential Revision: D87608082
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!