-
Notifications
You must be signed in to change notification settings - Fork 108
Fix leftover configuration from test_config.py #1971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dulinriley has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87664159. |
dulinriley
added a commit
to dulinriley/monarch
that referenced
this pull request
Nov 21, 2025
Summary:
Python tests on github failing with:
```
pyo3_runtime.PanicException: called `Result::unwrap()` on an `Err` value:
Server(Listen(Tcp([::1]:0),
Os { code: 99, kind: AddrNotAvailable, message: "Cannot assign requested address" }))
```
This is coming from a previous change,
meta-pytorch@e9e2030,
which re-enabled metrics which were accidentally disabled for a while.
Turn them back off for Github CI in the meantime.
Reviewed By: rusch95
Differential Revision: D87664159
86ff441 to
faf743a
Compare
dulinriley
added a commit
to dulinriley/monarch
that referenced
this pull request
Nov 21, 2025
Summary:
Python tests on github failing with:
```
pyo3_runtime.PanicException: called `Result::unwrap()` on an `Err` value:
Server(Listen(Tcp([::1]:0),
Os { code: 99, kind: AddrNotAvailable, message: "Cannot assign requested address" }))
```
This is coming from a previous change,
meta-pytorch@e9e2030,
which re-enabled metrics which were accidentally disabled for a while.
Turn them back off for Github CI in the meantime.
Reviewed By: rusch95
Differential Revision: D87664159
faf743a to
7f809c1
Compare
dulinriley
added a commit
to dulinriley/monarch
that referenced
this pull request
Nov 22, 2025
Summary:
Python tests on github failing with:
```
pyo3_runtime.PanicException: called `Result::unwrap()` on an `Err` value:
Server(Listen(Tcp([::1]:0),
Os { code: 99, kind: AddrNotAvailable, message: "Cannot assign requested address" }))
```
It is caused by the default transport for tests changing from unix -> tcp.
It's not clear what caused this change, but probably a new test was added that changed
the pytest-split groups.
Make sure test_config.py resets to the default state when it is done.
Differential Revision: D87664159
7f809c1 to
8177bb0
Compare
dulinriley
added a commit
to dulinriley/monarch
that referenced
this pull request
Nov 24, 2025
Summary:
Python tests on github failing with:
```
pyo3_runtime.PanicException: called `Result::unwrap()` on an `Err` value:
Server(Listen(Tcp([::1]:0),
Os { code: 99, kind: AddrNotAvailable, message: "Cannot assign requested address" }))
```
It is caused by the default transport for tests changing from unix -> tcp.
It's not clear what caused this change, but probably a new test was added that changed
the pytest-split groups.
Make sure test_config.py resets to the default state when it is done.
Reviewed By: rusch95
Differential Revision: D87664159
8177bb0 to
91828fd
Compare
dulinriley
added a commit
to dulinriley/monarch
that referenced
this pull request
Nov 24, 2025
Summary:
Python tests on github failing with:
```
pyo3_runtime.PanicException: called `Result::unwrap()` on an `Err` value:
Server(Listen(Tcp([::1]:0),
Os { code: 99, kind: AddrNotAvailable, message: "Cannot assign requested address" }))
```
It is caused by the default transport for tests changing from unix -> tcp.
It's not clear what caused this change, but probably a new test was added that changed
the pytest-split groups.
Make sure test_config.py resets to the default state when it is done.
Reviewed By: rusch95
Differential Revision: D87664159
91828fd to
f9e7f49
Compare
dulinriley
added a commit
to dulinriley/monarch
that referenced
this pull request
Nov 24, 2025
Summary:
Python tests on github failing with:
```
pyo3_runtime.PanicException: called `Result::unwrap()` on an `Err` value:
Server(Listen(Tcp([::1]:0),
Os { code: 99, kind: AddrNotAvailable, message: "Cannot assign requested address" }))
```
It is caused by the default transport for tests changing from unix -> tcp.
It's not clear what caused this change, but probably a new test was added that changed
the pytest-split groups.
Make sure test_config.py resets to the default state when it is done.
Reviewed By: rusch95
Differential Revision: D87664159
f9e7f49 to
5b7907f
Compare
Summary:
Python tests on github failing with:
```
pyo3_runtime.PanicException: called `Result::unwrap()` on an `Err` value:
Server(Listen(Tcp([::1]:0),
Os { code: 99, kind: AddrNotAvailable, message: "Cannot assign requested address" }))
```
It is caused by the default transport for tests changing from unix -> tcp.
It's not clear what caused this change, but probably a new test was added that changed
the pytest-split groups.
Make sure test_config.py resets to the default state when it is done.
Reviewed By: rusch95, shayne-fletcher
Differential Revision: D87664159
5b7907f to
8beffe1
Compare
|
This pull request has been merged in 6b22037. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Python tests on github failing with:
It is caused by the default transport for tests changing from unix -> tcp.
It's not clear what caused this change, but probably a new test was added that changed
the pytest-split groups.
Make sure test_config.py resets to the default state when it is done.
Differential Revision: D87664159