Add conda lib to static linker search path for builds #1972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@dulinriley has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87665225. |
dulinriley
force-pushed
the
export-D87665225
branch
from
64a7302 to
764b206
Compare
) Summary: Our install instructions say to use `conda install libunwind`, but the rust compiler is unable to locate it. Add a `-L` flag when building from within python to add the conda environment libraries. This should help rust locate the libraries it needs. Reviewed By: colin2328 Differential Revision: D87665225
dulinriley
force-pushed
the
export-D87665225
branch
from
764b206 to
667e17a
Compare
|
This pull request has been merged in d88c6f0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Our install instructions say to use
conda install libunwind, but the rust compileris unable to locate it.
Add a
-Lflag when building from within python to add the conda environment libraries.This should help rust locate the libraries it needs.
Differential Revision: D87665225