Skip to content

Remove unused python bindings to rust objects #1975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Remove unused python bindings to rust objects #1975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4336cd
Remove unused python bindings to rust objects
zdevito Nov 21, 2025
a3f84c2
Update on "Remove unused python bindings to rust objects"
zdevito Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion monarch_extension/src/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ use hyperactor_multiprocess::system_actor::SystemMessageClient;
use hyperactor_multiprocess::system_actor::SystemSnapshotFilter;
use hyperactor_multiprocess::system_actor::WorldSnapshot;
use hyperactor_multiprocess::system_actor::WorldSnapshotProcInfo;
use monarch_hyperactor::ndslice::PySlice;
use monarch_hyperactor::proc::ControllerError;
use monarch_hyperactor::proc::InstanceWrapper;
use monarch_hyperactor::proc::PyActorId;
Expand Down Expand Up @@ -51,9 +52,14 @@ use pyo3::types::PyNone;
use tokio::sync::Mutex;
use torch_sys::RValue;

use crate::controller::PyRanks;
use crate::convert::convert;

#[derive(Clone, FromPyObject)]
pub enum PyRanks {
Slice(PySlice),
SliceList(Vec<PySlice>),
}

#[pyclass(frozen, module = "monarch._rust_bindings.monarch_extension.client")]
pub struct WorkerResponse {
seq: Seq,
Expand Down
138 changes: 0 additions & 138 deletions monarch_extension/src/controller.rs
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions monarch_extension/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
mod client;
pub mod code_sync;
#[cfg(feature = "tensor_engine")]
mod controller;
#[cfg(feature = "tensor_engine")]
pub mod convert;
#[cfg(feature = "tensor_engine")]
mod debugger;
Expand Down Expand Up @@ -108,10 +106,6 @@ pub fn mod_init(module: &Bound<'_, PyModule>) -> PyResult<()> {
module,
"monarch_extension.tensor_worker",
)?)?;
controller::register_python_bindings(&get_or_add_new_module(
module,
"monarch_extension.controller",
)?)?;
debugger::register_python_bindings(&get_or_add_new_module(
module,
"monarch_extension.debugger",
Expand Down
Loading
Loading