Skip to content

Log events for SupervisionError::UnhandledFaultHook #1987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Log events for SupervisionError::UnhandledFaultHook #1987

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions monarch_hyperactor/src/v1/actor_mesh.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,11 @@ impl PythonActorMeshImpl {
.extract::<i32>()
.unwrap();
tracing::error!(
name = "ActorMeshStatus",
status = "SupervisionError::UnhandledFaultHook",
actor_name = failure.mesh_name,
event = %failure.event,
rank = failure.rank,
"unhandled event reached unhandled_fault_hook: {}, which is exiting the process with code {}",
failure,
code
Expand All @@ -275,6 +280,11 @@ impl PythonActorMeshImpl {
// The callback raised some other exception, and there's
// no way to handle it. Just exit the process anyways
tracing::error!(
name = "ActorMeshStatus",
status = "SupervisionError::UnhandledFaultHook",
actor_name = failure.mesh_name,
event = %failure.event,
rank = failure.rank,
"unhandled event reached unhandled_fault_hook: {}, which raised an exception: {:?}. \
Exiting the process with code 1",
failure,
Expand All @@ -284,6 +294,11 @@ impl PythonActorMeshImpl {
}
} else {
tracing::warn!(
name = "ActorMeshStatus",
status = "SupervisionError::UnhandledFaultHook",
actor_name = failure.mesh_name,
event = %failure.event,
rank = failure.rank,
"unhandled event reached unhandled_fault_hook: {}, but that function produced no exception or crash. Ignoring the error",
failure
);
Expand Down