Remove RValue env #1992
Open
Remove RValue env #1992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StreamWorker now directly stores a python environment rather than RValue. Now IValue/RValue are almost entirely unused within the workers, and WireValue is only used to interface with some tests. Follow ups will re-implement Tenosor/TensorCell as a wrapper around a python torch tensor. Then we can begin to remove torch-sys's libtorch bindings. Differential Revision: [D87835914](https://our.internmc.facebook.com/intern/diff/D87835914/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87835914/)! [ghstack-poisoned]
This was referenced Nov 24, 2025
meta-cla
bot
added
the
CLA Signed
zdevito
added a commit
that referenced
this pull request
Nov 25, 2025
StreamWorker now directly stores a python environment rather than RValue. Now IValue/RValue are almost entirely unused within the workers, and WireValue is only used to interface with some tests. Follow ups will re-implement Tenosor/TensorCell as a wrapper around a python torch tensor. Then we can begin to remove torch-sys's libtorch bindings. Differential Revision: [D87835914](https://our.internmc.facebook.com/intern/diff/D87835914/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87835914/)! ghstack-source-id: 325513410 Pull Request resolved: #1992
StreamWorker now directly stores a python environment rather than RValue. Now IValue/RValue are almost entirely unused within the workers, and WireValue is only used to interface with some tests. Follow ups will re-implement Tenosor/TensorCell as a wrapper around a python torch tensor. Then we can begin to remove torch-sys's libtorch bindings. Differential Revision: [D87835914](https://our.internmc.facebook.com/intern/diff/D87835914/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87835914/)! [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Nov 25, 2025
Pull Request resolved: #1992 StreamWorker now directly stores a python environment rather than RValue. Now IValue/RValue are almost entirely unused within the workers, and WireValue is only used to interface with some tests. Follow ups will re-implement Tenosor/TensorCell as a wrapper around a python torch tensor. Then we can begin to remove torch-sys's libtorch bindings. ghstack-source-id: 325670318 @exported-using-ghexport Differential Revision: [D87835914](https://our.internmc.facebook.com/intern/diff/D87835914/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87835914/)!
StreamWorker now directly stores a python environment rather than RValue. Now IValue/RValue are almost entirely unused within the workers, and WireValue is only used to interface with some tests. Follow ups will re-implement Tenosor/TensorCell as a wrapper around a python torch tensor. Then we can begin to remove torch-sys's libtorch bindings. Differential Revision: [D87835914](https://our.internmc.facebook.com/intern/diff/D87835914/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87835914/)! [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Nov 25, 2025
Pull Request resolved: #1992 StreamWorker now directly stores a python environment rather than RValue. Now IValue/RValue are almost entirely unused within the workers, and WireValue is only used to interface with some tests. Follow ups will re-implement Tenosor/TensorCell as a wrapper around a python torch tensor. Then we can begin to remove torch-sys's libtorch bindings. ghstack-source-id: 325672348 @exported-using-ghexport Differential Revision: [D87835914](https://our.internmc.facebook.com/intern/diff/D87835914/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87835914/)!
StreamWorker now directly stores a python environment rather than RValue. Now IValue/RValue are almost entirely unused within the workers, and WireValue is only used to interface with some tests. Follow ups will re-implement Tenosor/TensorCell as a wrapper around a python torch tensor. Then we can begin to remove torch-sys's libtorch bindings. Differential Revision: [D87835914](https://our.internmc.facebook.com/intern/diff/D87835914/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87835914/)! [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Nov 26, 2025
Pull Request resolved: #1992 StreamWorker now directly stores a python environment rather than RValue. Now IValue/RValue are almost entirely unused within the workers, and WireValue is only used to interface with some tests. Follow ups will re-implement Tenosor/TensorCell as a wrapper around a python torch tensor. Then we can begin to remove torch-sys's libtorch bindings. ghstack-source-id: 325689672 @exported-using-ghexport Differential Revision: [D87835914](https://our.internmc.facebook.com/intern/diff/D87835914/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87835914/)!
StreamWorker now directly stores a python environment rather than RValue. Now IValue/RValue are almost entirely unused within the workers, and WireValue is only used to interface with some tests. Follow ups will re-implement Tenosor/TensorCell as a wrapper around a python torch tensor. Then we can begin to remove torch-sys's libtorch bindings. Differential Revision: [D87835914](https://our.internmc.facebook.com/intern/diff/D87835914/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87835914/)! [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Nov 26, 2025
Pull Request resolved: #1992 StreamWorker now directly stores a python environment rather than RValue. Now IValue/RValue are almost entirely unused within the workers, and WireValue is only used to interface with some tests. Follow ups will re-implement Tenosor/TensorCell as a wrapper around a python torch tensor. Then we can begin to remove torch-sys's libtorch bindings. ghstack-source-id: 325827694 @exported-using-ghexport Differential Revision: [D87835914](https://our.internmc.facebook.com/intern/diff/D87835914/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D87835914/)!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
StreamWorker now directly stores a python environment rather than RValue. Now IValue/RValue are almost entirely unused within the workers, and WireValue is only used to interface with some tests. Follow ups will re-implement Tenosor/TensorCell as a wrapper around a python torch tensor. Then we can begin to remove torch-sys's libtorch bindings.
Differential Revision: D87835914
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!