[monarch] add test for process allocator child cleanup #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test that if we kill the ProcessAllocator process, children will get cleaned up. This will be used to confirm our removal of HYPERACTOR_MANAGED_SUBPROCESS is ok. Differential Revision: [D77348271](https://our.internmc.facebook.com/intern/diff/D77348271/) [ghstack-poisoned]
suo
added a commit
that referenced
this pull request
Jun 26, 2025
Test that if we kill the ProcessAllocator process, children will get cleaned up. This will be used to confirm our removal of HYPERACTOR_MANAGED_SUBPROCESS is ok. Differential Revision: [D77348271](https://our.internmc.facebook.com/intern/diff/D77348271/) ghstack-source-id: 292769895 Pull Request resolved: #348
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77348271 |
Test that if we kill the ProcessAllocator process, children will get cleaned up. This will be used to confirm our removal of HYPERACTOR_MANAGED_SUBPROCESS is ok. Differential Revision: [D77348271](https://our.internmc.facebook.com/intern/diff/D77348271/) [ghstack-poisoned]
suo
added a commit
that referenced
this pull request
Jun 26, 2025
Pull Request resolved: #348 Test that if we kill the ProcessAllocator process, children will get cleaned up. This will be used to confirm our removal of HYPERACTOR_MANAGED_SUBPROCESS is ok. Differential Revision: [D77348271](https://our.internmc.facebook.com/intern/diff/D77348271/) ghstack-source-id: 292906587
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77348271 |
Test that if we kill the ProcessAllocator process, children will get cleaned up. This will be used to confirm our removal of HYPERACTOR_MANAGED_SUBPROCESS is ok. Differential Revision: [D77348271](https://our.internmc.facebook.com/intern/diff/D77348271/) [ghstack-poisoned]
suo
added a commit
that referenced
this pull request
Jun 26, 2025
Pull Request resolved: #348 Test that if we kill the ProcessAllocator process, children will get cleaned up. This will be used to confirm our removal of HYPERACTOR_MANAGED_SUBPROCESS is ok. ghstack-source-id: 292906985 Differential Revision: [D77348271](https://our.internmc.facebook.com/intern/diff/D77348271/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77348271 |
Test that if we kill the ProcessAllocator process, children will get cleaned up. This will be used to confirm our removal of HYPERACTOR_MANAGED_SUBPROCESS is ok. Differential Revision: [D77348271](https://our.internmc.facebook.com/intern/diff/D77348271/) [ghstack-poisoned]
suo
added a commit
that referenced
this pull request
Jun 26, 2025
Pull Request resolved: #348 Test that if we kill the ProcessAllocator process, children will get cleaned up. This will be used to confirm our removal of HYPERACTOR_MANAGED_SUBPROCESS is ok. ghstack-source-id: 292920078 Differential Revision: [D77348271](https://our.internmc.facebook.com/intern/diff/D77348271/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77348271 |
Test that if we kill the ProcessAllocator process, children will get cleaned up. This will be used to confirm our removal of HYPERACTOR_MANAGED_SUBPROCESS is ok. Differential Revision: [D77348271](https://our.internmc.facebook.com/intern/diff/D77348271/) [ghstack-poisoned]
suo
added a commit
that referenced
this pull request
Jun 26, 2025
Pull Request resolved: #348 Test that if we kill the ProcessAllocator process, children will get cleaned up. This will be used to confirm our removal of HYPERACTOR_MANAGED_SUBPROCESS is ok. ghstack-source-id: 292926559 Differential Revision: [D77348271](https://our.internmc.facebook.com/intern/diff/D77348271/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77348271 |
Test that if we kill the ProcessAllocator process, children will get cleaned up. This will be used to confirm our removal of HYPERACTOR_MANAGED_SUBPROCESS is ok. Differential Revision: [D77348271](https://our.internmc.facebook.com/intern/diff/D77348271/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77348271 |
Test that if we kill the ProcessAllocator process, children will get cleaned up. This will be used to confirm our removal of HYPERACTOR_MANAGED_SUBPROCESS is ok. Differential Revision: [D77348271](https://our.internmc.facebook.com/intern/diff/D77348271/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77348271 |
Contributor
|
This pull request has been merged in 6b21a61. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Test that if we kill the ProcessAllocator process, children will get cleaned up.
This will be used to confirm our removal of HYPERACTOR_MANAGED_SUBPROCESS is ok.
Differential Revision: D77348271