[hyperactor] general in-proc ActorRef -> ActorHandle downcasting #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide a general purpose mechanism for downcasting any local (in-proc) ActorRef<A> to its corresponding ActorHandle<A>. This allows these references to be coordinated externally, but for the actors to communicate locally (including using handlers that aren't exported, e.g., because they may not contain serializable messages). The intent is to use this in the tensor engine, to allow the controller to instruct actors to coordinate locally, passing objects like tensor references directly. This required building a general instance registration mechanism, which we can use to replace the ledger in a follow-up change. Differential Revision: [D77377382](https://our.internmc.facebook.com/intern/diff/D77377382/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D77377382/)! [ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Jun 26, 2025
Provide a general purpose mechanism for downcasting any local (in-proc) ActorRef<A> to its corresponding ActorHandle<A>. This allows these references to be coordinated externally, but for the actors to communicate locally (including using handlers that aren't exported, e.g., because they may not contain serializable messages). The intent is to use this in the tensor engine, to allow the controller to instruct actors to coordinate locally, passing objects like tensor references directly. This required building a general instance registration mechanism, which we can use to replace the ledger in a follow-up change. Differential Revision: [D77377382](https://our.internmc.facebook.com/intern/diff/D77377382/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D77377382/)! ghstack-source-id: 292858405 Pull Request resolved: #350
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77377382 |
…asting" Provide a general purpose mechanism for downcasting any local (in-proc) ActorRef<A> to its corresponding ActorHandle<A>. This allows these references to be coordinated externally, but for the actors to communicate locally (including using handlers that aren't exported, e.g., because they may not contain serializable messages). The intent is to use this in the tensor engine, to allow the controller to instruct actors to coordinate locally, passing objects like tensor references directly. This required building a general instance registration mechanism, which we can use to replace the ledger in a follow-up change. Differential Revision: [D77377382](https://our.internmc.facebook.com/intern/diff/D77377382/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D77377382/)! [ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Jun 26, 2025
Pull Request resolved: #350 Provide a general purpose mechanism for downcasting any local (in-proc) ActorRef<A> to its corresponding ActorHandle<A>. This allows these references to be coordinated externally, but for the actors to communicate locally (including using handlers that aren't exported, e.g., because they may not contain serializable messages). The intent is to use this in the tensor engine, to allow the controller to instruct actors to coordinate locally, passing objects like tensor references directly. This required building a general instance registration mechanism, which we can use to replace the ledger in a follow-up change. Differential Revision: [D77377382](https://our.internmc.facebook.com/intern/diff/D77377382/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D77377382/)! ghstack-source-id: 292911240
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77377382 |
…asting" Provide a general purpose mechanism for downcasting any local (in-proc) ActorRef<A> to its corresponding ActorHandle<A>. This allows these references to be coordinated externally, but for the actors to communicate locally (including using handlers that aren't exported, e.g., because they may not contain serializable messages). The intent is to use this in the tensor engine, to allow the controller to instruct actors to coordinate locally, passing objects like tensor references directly. This required building a general instance registration mechanism, which we can use to replace the ledger in a follow-up change. Differential Revision: [D77377382](https://our.internmc.facebook.com/intern/diff/D77377382/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D77377382/)! [ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Jun 26, 2025
Pull Request resolved: #350 Provide a general purpose mechanism for downcasting any local (in-proc) ActorRef<A> to its corresponding ActorHandle<A>. This allows these references to be coordinated externally, but for the actors to communicate locally (including using handlers that aren't exported, e.g., because they may not contain serializable messages). The intent is to use this in the tensor engine, to allow the controller to instruct actors to coordinate locally, passing objects like tensor references directly. This required building a general instance registration mechanism, which we can use to replace the ledger in a follow-up change. ghstack-source-id: 292922123 Differential Revision: [D77377382](https://our.internmc.facebook.com/intern/diff/D77377382/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D77377382/)!
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77377382 |
This was referenced Jun 26, 2025
Closed
…asting" Provide a general purpose mechanism for downcasting any local (in-proc) ActorRef<A> to its corresponding ActorHandle<A>. This allows these references to be coordinated externally, but for the actors to communicate locally (including using handlers that aren't exported, e.g., because they may not contain serializable messages). The intent is to use this in the tensor engine, to allow the controller to instruct actors to coordinate locally, passing objects like tensor references directly. This required building a general instance registration mechanism, which we can use to replace the ledger in a follow-up change. Differential Revision: [D77377382](https://our.internmc.facebook.com/intern/diff/D77377382/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D77377382/)! [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77377382 |
…asting" Provide a general purpose mechanism for downcasting any local (in-proc) ActorRef<A> to its corresponding ActorHandle<A>. This allows these references to be coordinated externally, but for the actors to communicate locally (including using handlers that aren't exported, e.g., because they may not contain serializable messages). The intent is to use this in the tensor engine, to allow the controller to instruct actors to coordinate locally, passing objects like tensor references directly. This required building a general instance registration mechanism, which we can use to replace the ledger in a follow-up change. Differential Revision: [D77377382](https://our.internmc.facebook.com/intern/diff/D77377382/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D77377382/)! [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77377382 |
Contributor
|
This pull request has been merged in 012342d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Provide a general purpose mechanism for downcasting any local (in-proc) ActorRef to its corresponding ActorHandle. This allows these references to be coordinated externally, but for the actors to communicate locally (including using handlers that aren't exported, e.g., because they may not contain serializable messages).
The intent is to use this in the tensor engine, to allow the controller to instruct actors to coordinate locally, passing objects like tensor references directly.
This required building a general instance registration mechanism, which we can use to replace the ledger in a follow-up change.
Differential Revision: D77377382
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!