[10/n] restore debugger support to mesh_controller #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moves the debugger support directly into the controller actor so there is no need to shuttle messages back/forth from the client. Differential Revision: [D77771081](https://our.internmc.facebook.com/intern/diff/D77771081/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D77771081/)! [ghstack-poisoned]
This was referenced Jul 4, 2025
Closed
zdevito
added a commit
that referenced
this pull request
Jul 4, 2025
moves the debugger support directly into the controller actor so there is no need to shuttle messages back/forth from the client. Differential Revision: [D77771081](https://our.internmc.facebook.com/intern/diff/D77771081/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D77771081/)! ghstack-source-id: 294259040 Pull Request resolved: #433
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77771081 |
moves the debugger support directly into the controller actor so there is no need to shuttle messages back/forth from the client. Differential Revision: [D77771081](https://our.internmc.facebook.com/intern/diff/D77771081/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D77771081/)! [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Jul 7, 2025
Pull Request resolved: #433 moves the debugger support directly into the controller actor so there is no need to shuttle messages back/forth from the client. Differential Revision: [D77771081](https://our.internmc.facebook.com/intern/diff/D77771081/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D77771081/)! ghstack-source-id: 294608438
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77771081 |
Contributor
|
This pull request has been merged in 5930c52. |
This was referenced Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
moves the debugger support directly into the controller actor so there is no need to shuttle messages back/forth from the client.
Differential Revision: D77771081
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!