Rust code looks pretty good - minor nits #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezyang
approved these changes
Feb 29, 2024
| #[derive(Debug, Deserialize)] | ||
| struct DynamoOutputGraphMetadata { | ||
| sizes: Option<FxHashMap<String, Vec<SymInt>>>, | ||
| _sizes: Option<FxHashMap<String, Vec<SymInt>>>, |
There was a problem hiding this comment.
Does this change serde's behavior? I need the field to match what I am getting in the JSON format
There was a problem hiding this comment.
It will change the field name - so if you need it to match the JSON name then you can prefix it with:
#[allow(dead_code)]
sizes: Option<FxHashMap<String, Vec<SymInt>>>,
so it doesn't complain about the unread field.
There was a problem hiding this comment.
ok, i'll need to do this. fortunately these are all defaulted so it doesn't matter too much yet
| .map_or(format!("unknown_{}", lineno), |e: CompileId| { | ||
| format!("{}_{}_{}", e.frame_id, e.frame_compile_id, e.attempt) | ||
| }); | ||
| .as_ref() |
| frame_id, | ||
| frame_compile_id, | ||
| attempt, | ||
| }| { format!("{frame_id}_{frame_compile_id}_{attempt}") }, |
There was a problem hiding this comment.
huh, f-string style is nice
There was a problem hiding this comment.
Just be aware that it only works with identifiers - so you can't do:
format!("{foo.bar}")
but you can do:
format!("{myvar}", myvar = foo.bar)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are my suggestions - they're all pretty minor however. The biggest one is just the use of Result +
?in main - getting used to the rust style of error handling is pretty key since it's pretty pervasive.