Skip to content

Add Voxtral test. #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2025
Merged

Add Voxtral test. #136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 1 addition & 35 deletions src/pre_tokenizer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,44 +144,10 @@ PreTokenizerConfig& PreTokenizerConfig::parse_json(const json& json_config) {

// RegexPreTokenizer ///////////////////////////////////////////////////////////

namespace {

// Make Hugging Face Split patterns RE2-compatible by:
// 1) removing the negative look-ahead "\s+(?!\S)" (→ "\s+$")
// 2) expanding the inline case-insensitive contractions
// "(?i:'s|'t|'re|'ve|'m|'ll|'d)" into explicit alternations.
static void replace_all_in_place(
std::string& input,
const std::string& needle,
const std::string& replacement) {
if (needle.empty()) {
return;
}
size_t search_pos = 0;
while ((search_pos = input.find(needle, search_pos)) != std::string::npos) {
input.replace(search_pos, needle.size(), replacement);
search_pos += replacement.size();
}
}

static std::string make_re2_compatible(std::string pattern) {
const std::string lookahead_trailing_space = R"(\s+(?!\S))";
const std::string trailing_space_replacement = R"(\s+$)";
replace_all_in_place(
pattern, lookahead_trailing_space, trailing_space_replacement);
const std::string ci_contractions = R"((?i:'s|'t|'re|'ve|'m|'ll|'d))";
const std::string contractions_expanded =
"(?:'s|'S|'t|'T|'re|'RE|'ve|'VE|'m|'M|'ll|'LL|'d|'D)";
replace_all_in_place(pattern, ci_contractions, contractions_expanded);
return pattern;
}

} // namespace

std::unique_ptr<IRegex> RegexPreTokenizer::create_regex_(
const std::string& pattern) {
assert(!pattern.empty());
return TK_UNWRAP_THROW(create_regex(make_re2_compatible(pattern)));
return TK_UNWRAP_THROW(create_regex(pattern));
}

std::vector<std::string> RegexPreTokenizer::pre_tokenize(
Expand Down