Drop src/torchcodec/_core/ when including headers from _core #1002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To facilitate development of out-of-tree torchcodec features (such as non-cuda gpu plugins) we need to make torchcodec headers includable by 3rd party projects. This means dropping `src/torchcodec/_core/` prefix when torchcodec self-includes headers. Signed-off-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@gmail.com>
meta-cla
bot
added
the
CLA Signed
|
Ah, I forgot to run lint locally. Sorry for that and thank you for the fix @NicolasHug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #938 (comment).
To facilitate development of out-of-tree torchcodec features (such as non-cuda gpu plugins) we need to make torchcodec headers includable by 3rd party projects. This means dropping
src/torchcodec/_core/prefix when torchcodec self-includes headers.CC: @scotts @NicolasHug