Add preset to VideoEncoder API #1042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
NicolasHug
approved these changes
Nov 13, 2025
Contributor
NicolasHug
left a comment
NicolasHug
left a comment
There was a problem hiding this comment.
Thanks @Dan-Flores , 9eee77f LGTM.
Did you empirically observe the effect of this parameter, e.g. does using preset="slow" produce a smaller output file than using preset="fast"?
Contributor
Author
Yes, I originally had a test for this but felt it had potential to be flaky. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds preset as an option in the VideoEncoder API, and is build on the CRF changes in #1031.
To review just these changes, see 9eee77f
presetis a readable string in libx264, so the docstring suggests those strings. Occasionally (as in the case of thelibsvtav1codec),presetcan be anint, so both types are accepted.To test, test_video_encoder_against_ffmpeg_cli is updated to try combinations of pixel_format, crf, and preset.