Refactor _make_transform_specs() location #1097
Merged
+101
−100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Dan-Flores
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on #1094 made me realize that if
_make_transform_specs()continues to live in_video_decoder.py, it will linearly grow in size as we add transforms, and the additions will be boiler-plate code. We should try to keep the code in_video_decoder.pyspecific to the actualVideoDecoderpublic API. l think making_make_transform_specs()live intorchcodec.transformsis cleaner, particularly since we have a clear API (transforms go in, string specs come out).I also realized that over time, we might want the transforms files to start mirroring how they're structured in TorchVision, but we can put that off we have enough transforms it starts being an organizational problem.