Skip to content

Conversation

ahmadsharif1
Copy link
Contributor

Summary:
Not sure if we will ever hit this case, but this may be a reason why TorchCodec is crashing on some videos.

Maybe the user passes in a negative value for size and it trickles all the way to the read function. We should not be treating negative sizes as large sizes.

Reviewed By: scotts

Differential Revision: D60461269

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jul 30, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60461269

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60461269

Summary:
Pull Request resolved: #131

Not sure if we will ever hit this case, but this may be a reason why TorchCodec is crashing on some videos.

Maybe the user passes in a negative value for size and it trickles all the way to the read function. We should not be treating negative sizes as large sizes.

Reviewed By: scotts

Differential Revision: D60461269
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D60461269

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in e43a20f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot. fb-exported Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants