[torchcodec] Return subsequent frame if FFMPEG seeks past end of the frame #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61139386 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61139386 |
ahmadsharif1
added a commit
to ahmadsharif1/torchcodec
that referenced
this pull request
Aug 12, 2024
…frame (meta-pytorch#178) Summary: Pull Request resolved: meta-pytorch#178 The way get_frame_displayed_at works is as follows: We call avformat_seek_file with: `min_ts=-inf ts=timestamp max_ts=timestamp` https://ffmpeg.org/doxygen/7.0/group__lavf__decoding.html#ga3b40fc8d2fda6992ae6ea2567d71ba30 This should in theory never seek past our timestamp. However for some videos ffmpeg does seek past our timestamp. And that causes us to never return a valid frame in that case. The fix is to warn the user and return the first frame after the timestamp if this ever happens. Differential Revision: D61139386
ahmadsharif1
force-pushed
the
export-D61139386
branch
from
066f137 to
c9bb63a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61139386 |
ahmadsharif1
added a commit
to ahmadsharif1/torchcodec
that referenced
this pull request
Aug 12, 2024
…frame (meta-pytorch#178) Summary: Pull Request resolved: meta-pytorch#178 The way get_frame_displayed_at works is as follows: We call avformat_seek_file with: `min_ts=-inf ts=timestamp max_ts=timestamp` https://ffmpeg.org/doxygen/7.0/group__lavf__decoding.html#ga3b40fc8d2fda6992ae6ea2567d71ba30 This should in theory never seek past our timestamp. However for some videos ffmpeg does seek past our timestamp. And that causes us to never return a valid frame in that case. The fix is to warn the user and return the first frame after the timestamp if this ever happens. Differential Revision: D61139386
ahmadsharif1
force-pushed
the
export-D61139386
branch
from
c9bb63a to
1a36dea
Compare
ahmadsharif1
added a commit
to ahmadsharif1/torchcodec
that referenced
this pull request
Aug 12, 2024
…frame (meta-pytorch#178) Summary: Pull Request resolved: meta-pytorch#178 The way get_frame_displayed_at works is as follows: We call avformat_seek_file with: `min_ts=-inf ts=timestamp max_ts=timestamp` https://ffmpeg.org/doxygen/7.0/group__lavf__decoding.html#ga3b40fc8d2fda6992ae6ea2567d71ba30 This should in theory never seek past our timestamp. However for some videos ffmpeg does seek past our timestamp. And that causes us to never return a valid frame in that case. The fix is to warn the user and return the first frame after the timestamp if this ever happens. Differential Revision: D61139386
ahmadsharif1
force-pushed
the
export-D61139386
branch
from
1a36dea to
87350b9
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61139386 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61139386 |
ahmadsharif1
added a commit
to ahmadsharif1/torchcodec
that referenced
this pull request
Aug 12, 2024
…frame (meta-pytorch#178) Summary: Pull Request resolved: meta-pytorch#178 The way get_frame_displayed_at works is as follows: We call avformat_seek_file with: `min_ts=-inf ts=timestamp max_ts=timestamp` https://ffmpeg.org/doxygen/7.0/group__lavf__decoding.html#ga3b40fc8d2fda6992ae6ea2567d71ba30 This should in theory never seek past our timestamp. However for some videos ffmpeg does seek past our timestamp. And that causes us to never return a valid frame in that case. The fix is to warn the user and return the first frame after the timestamp if this ever happens. Differential Revision: D61139386
ahmadsharif1
force-pushed
the
export-D61139386
branch
from
87350b9 to
a8335aa
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61139386 |
ahmadsharif1
added a commit
to ahmadsharif1/torchcodec
that referenced
this pull request
Aug 12, 2024
…frame (meta-pytorch#178) Summary: Pull Request resolved: meta-pytorch#178 The way get_frame_displayed_at works is as follows: We call avformat_seek_file with: `min_ts=-inf ts=timestamp max_ts=timestamp` https://ffmpeg.org/doxygen/7.0/group__lavf__decoding.html#ga3b40fc8d2fda6992ae6ea2567d71ba30 This should in theory never seek past our timestamp. However for some videos ffmpeg does seek past our timestamp. And that causes us to never return a valid frame in that case. The fix is to warn the user and return the first frame after the timestamp if this ever happens. Differential Revision: D61139386
ahmadsharif1
force-pushed
the
export-D61139386
branch
from
a8335aa to
317d32a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61139386 |
ahmadsharif1
added a commit
to ahmadsharif1/torchcodec
that referenced
this pull request
Aug 12, 2024
…frame (meta-pytorch#178) Summary: Pull Request resolved: meta-pytorch#178 The way get_frame_displayed_at works is as follows: We call avformat_seek_file with: `min_ts=-inf ts=timestamp max_ts=timestamp` https://ffmpeg.org/doxygen/7.0/group__lavf__decoding.html#ga3b40fc8d2fda6992ae6ea2567d71ba30 This should in theory never seek past our timestamp. However for some videos ffmpeg does seek past our timestamp. And that causes us to never return a valid frame in that case. The fix is to warn the user and return the first frame after the timestamp if this ever happens. Differential Revision: D61139386
ahmadsharif1
force-pushed
the
export-D61139386
branch
from
317d32a to
9cf11fc
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61139386 |
ahmadsharif1
added a commit
to ahmadsharif1/torchcodec
that referenced
this pull request
Aug 13, 2024
…frame (meta-pytorch#178) Summary: Pull Request resolved: meta-pytorch#178 The way get_frame_displayed_at works is as follows: We call avformat_seek_file with: `min_ts=-inf ts=timestamp max_ts=timestamp` https://ffmpeg.org/doxygen/7.0/group__lavf__decoding.html#ga3b40fc8d2fda6992ae6ea2567d71ba30 This should in theory never seek past our timestamp. However for some videos ffmpeg does seek past our timestamp. And that causes us to never return a valid frame in that case. The fix is to warn the user and return the first frame after the timestamp if this ever happens. Differential Revision: D61139386
ahmadsharif1
force-pushed
the
export-D61139386
branch
from
9cf11fc to
10577b2
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61139386 |
ahmadsharif1
added a commit
to ahmadsharif1/torchcodec
that referenced
this pull request
Aug 13, 2024
…frame (meta-pytorch#178) Summary: Pull Request resolved: meta-pytorch#178 The way get_frame_displayed_at works is as follows: We call avformat_seek_file with: `min_ts=-inf ts=timestamp max_ts=timestamp` https://ffmpeg.org/doxygen/7.0/group__lavf__decoding.html#ga3b40fc8d2fda6992ae6ea2567d71ba30 This should in theory never seek past our timestamp. However for some videos ffmpeg does seek past our timestamp. And that causes us to never return a valid frame in that case. The fix is to warn the user and return the first frame after the timestamp if this ever happens. Differential Revision: D61139386
ahmadsharif1
force-pushed
the
export-D61139386
branch
from
10577b2 to
f4b70b1
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61139386 |
ahmadsharif1
added a commit
to ahmadsharif1/torchcodec
that referenced
this pull request
Aug 13, 2024
…frame (meta-pytorch#178) Summary: Pull Request resolved: meta-pytorch#178 The way get_frame_displayed_at works is as follows: We call avformat_seek_file with: `min_ts=-inf ts=timestamp max_ts=timestamp` https://ffmpeg.org/doxygen/7.0/group__lavf__decoding.html#ga3b40fc8d2fda6992ae6ea2567d71ba30 This should in theory never seek past our timestamp. However for some videos ffmpeg does seek past our timestamp. And that causes us to never return a valid frame in that case. The fix is to warn the user and return the first frame after the timestamp if this ever happens. Reviewed By: NicolasHug Differential Revision: D61139386
ahmadsharif1
force-pushed
the
export-D61139386
branch
from
f4b70b1 to
d6d70ad
Compare
ahmadsharif1
added a commit
to ahmadsharif1/torchcodec
that referenced
this pull request
Aug 13, 2024
…frame (meta-pytorch#178) Summary: Pull Request resolved: meta-pytorch#178 The way get_frame_displayed_at works is as follows: We call avformat_seek_file with: `min_ts=-inf ts=timestamp max_ts=timestamp` https://ffmpeg.org/doxygen/7.0/group__lavf__decoding.html#ga3b40fc8d2fda6992ae6ea2567d71ba30 This should in theory never seek past our timestamp. However for some videos ffmpeg does seek past our timestamp. And that causes us to never return a valid frame in that case. The fix is to warn the user and return the first frame after the timestamp if this ever happens. Reviewed By: NicolasHug Differential Revision: D61139386
ahmadsharif1
force-pushed
the
export-D61139386
branch
from
d6d70ad to
d64946a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61139386 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61139386 |
ahmadsharif1
added a commit
to ahmadsharif1/torchcodec
that referenced
this pull request
Aug 13, 2024
…frame (meta-pytorch#178) Summary: Pull Request resolved: meta-pytorch#178 The way get_frame_displayed_at works is as follows: We call avformat_seek_file with: `min_ts=-inf ts=timestamp max_ts=timestamp` https://ffmpeg.org/doxygen/7.0/group__lavf__decoding.html#ga3b40fc8d2fda6992ae6ea2567d71ba30 This should in theory never seek past our timestamp. However for some videos ffmpeg does seek past our timestamp. And that causes us to never return a valid frame in that case. The fix is to warn the user and return the first frame after the timestamp if this ever happens. Reviewed By: NicolasHug Differential Revision: D61139386
ahmadsharif1
force-pushed
the
export-D61139386
branch
from
d64946a to
31adc68
Compare
…frame (meta-pytorch#178) Summary: Pull Request resolved: meta-pytorch#178 The way get_frame_displayed_at works is as follows: We call avformat_seek_file with: `min_ts=-inf ts=timestamp max_ts=timestamp` https://ffmpeg.org/doxygen/7.0/group__lavf__decoding.html#ga3b40fc8d2fda6992ae6ea2567d71ba30 This should in theory never seek past our timestamp. However for some videos ffmpeg does seek past our timestamp. And that causes us to never return a valid frame in that case. The fix is to warn the user and return the first frame after the timestamp if this ever happens. Reviewed By: NicolasHug Differential Revision: D61139386
ahmadsharif1
force-pushed
the
export-D61139386
branch
from
31adc68 to
b1d4996
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61139386 |
NicolasHug
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The way get_frame_displayed_at works is as follows:
We call avformat_seek_file with:
min_ts=-inf ts=timestamp max_ts=timestamphttps://ffmpeg.org/doxygen/7.0/group__lavf__decoding.html#ga3b40fc8d2fda6992ae6ea2567d71ba30
This should in theory never seek past our timestamp.
However for some videos ffmpeg does seek past our timestamp.
And that causes us to never return a valid frame in that case.
The fix is to warn the user and return the first frame after the timestamp if this ever happens.
Differential Revision: D61139386