Refactor Frame and FrameBatch into their own source file #247
Conversation
facebook-github-bot
added
the
CLA Signed
|
@scotts has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
NicolasHug
left a comment
NicolasHug
left a comment
There was a problem hiding this comment.
LGTM with one small request to move it one level up
There was a problem hiding this comment.
Can you actually move this file one level up into src/torchcodec/? We'll need that to expose them in torchcodec as discussed in #221 (comment)
There was a problem hiding this comment.
I remembered that discussion, but got the conclusion wrong. :)
|
@scotts has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@scotts has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@scotts has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@scotts has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
4 participants
This will simplify my future PRs where we start implementing
SingleStreamDecoder.