Skip to content

New samplers benchmark #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2024
Merged

New samplers benchmark #248

merged 1 commit into from
Oct 8, 2024

Conversation

@NicolasHug
Copy link
Contributor

@NicolasHug NicolasHug commented Oct 8, 2024

This PR replaces the existing samplers benchmark (old, using the private and deprecated samplers). The new benchmark is the one that was used in #245

Test:

~/dev/torchcodec (benchmark_samplers*) » python benchmarks/samplers/benchmark_samplers.py   
med = 36.88ms +- 8.55
med = 289.40ms +- 273.97

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 8, 2024
@NicolasHug NicolasHug merged commit 2c59958 into main Oct 8, 2024
16 of 22 checks passed
@NicolasHug NicolasHug deleted the benchmark_samplers branch October 8, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scotts scotts scotts approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NicolasHug @scotts @facebook-github-bot