Skip to content

Conversation

@scotts
Copy link
Contributor

@scotts scotts commented Oct 17, 2024

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 17, 2024
@scotts scotts marked this pull request as ready for review October 17, 2024 19:52
StreamInfo& activeStream = streams_[frameStreamIndex];
return frame->pts >=
activeStream.discardFramesBeforePts;
return frame->pts >= activeStream.discardFramesBeforePts;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need the same clang-format: off comment here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, as this formats the same in both places. I'm not sure how this got committed as-is.

@NicolasHug
Copy link
Contributor

I think this was caused by a new clang version or something? I'm hitting the same issue on my own PR so I'll merge this now to avoid conflicts

@NicolasHug NicolasHug merged commit 74961d2 into meta-pytorch:main Oct 18, 2024
24 checks passed
@scotts scotts deleted the lint_fix branch June 23, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants