Skip to content

Conversation

@ahmadsharif1
Copy link
Contributor

@ahmadsharif1 ahmadsharif1 commented Oct 25, 2024

Otherwise I sometimes see torchvision CPU changing the underlying torch version which removes critical cuda libraries and we see test failures:

image

https://github.com/pytorch/torchcodec/actions/runs/11517533038/job/32062818448?pr=294

Note that I had to use my own fork of test-infra until pytorch/test-infra#5821 is merged into main. I'll update this to use main once pytorch/test-infra#5821 is merged.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 25, 2024
Copy link
Contributor

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if green!

@ahmadsharif1 ahmadsharif1 marked this pull request as ready for review October 25, 2024 13:33
@ahmadsharif1 ahmadsharif1 merged commit 230abbf into meta-pytorch:main Oct 25, 2024
40 checks passed
@ahmadsharif1 ahmadsharif1 deleted the nocpu branch October 25, 2024 18:41
huydhn pushed a commit to pytorch/test-infra that referenced this pull request Oct 25, 2024
Without this there would be cache collisions of different
default-packages. i.e. the symptom I was seeing was the cache
would restore my conda environment but without the packages.

I tested it here with torchcodec
meta-pytorch/torchcodec#298


https://github.com/pytorch/torchcodec/actions/runs/11523232397/job/32081186451?pr=298

And it seems to be working fine.

Example the cache key contains the package hashes:

<img width="1193" alt="image"
src="https://github.com/user-attachments/assets/f04d6ac9-ff72-4f07-b5ef-831b6d3fd09f">
ahmadsharif1 added a commit to ahmadsharif1/test-infra that referenced this pull request Nov 13, 2024
Without this there would be cache collisions of different
default-packages. i.e. the symptom I was seeing was the cache
would restore my conda environment but without the packages.

I tested it here with torchcodec
meta-pytorch/torchcodec#298


https://github.com/pytorch/torchcodec/actions/runs/11523232397/job/32081186451?pr=298

And it seems to be working fine.

Example the cache key contains the package hashes:

<img width="1193" alt="image"
src="https://github.com/user-attachments/assets/f04d6ac9-ff72-4f07-b5ef-831b6d3fd09f">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants