Remove preAllocatedTensor from getFrameAtIndex #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
NicolasHug
commented
Oct 30, 2024
|
|
||
| DecodedOutput getFrameAtIndex( | ||
| DecodedOutput getFrameAtIndex(int streamIndex, int64_t frameIndex); | ||
| DecodedOutput getFrameAtIndexInternal( |
Contributor
Author
There was a problem hiding this comment.
I had to move this one back to public unfortunately, because we must now rely on this one for our C++ tests. Eventually once we accept pre-allocated tensors in all high-level entrypoints, we'll be able to move it back to private.
Contributor
There was a problem hiding this comment.
We could also use the friend declaration, but I'd prefer not to even mention the testing class in the implementation. I think this is fine.
Can we put a comment here, saying that morally this is a private member function, and the conditions for making it so?
scotts
approved these changes
Oct 30, 2024
ahmadsharif1
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small clean-up that I forgot to do in #317
getFrameAtIndex()was / is never called with its optionalpreAllocatedTensorOutputparameter, so this PR removes it. This makesgetFrameAtIndex()consistent with the other high-level entry-points, which do not acceptpreAllocatedTensorOutputeither.In the future, we'll probably want to put back this parameter for users to pass their own pre-allocated tensors, but we should add that consistently across all entry-points.