Skip to content

Conversation

@scotts
Copy link
Contributor

@scotts scotts commented Nov 20, 2024

This also reorients the data file itself to be structured as:

{
  "experiments":
    [
      # list of individual experiments
    ]
  "system_metadata":
    {
      # key-value pairs of metadata
    }
}

Because this changes the data file, I'll wait until the current experiments are done, and then I'll merge things manually.

@scotts scotts requested a review from ahmadsharif1 November 20, 2024 20:16
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 20, 2024
@scotts scotts marked this pull request as ready for review November 20, 2024 20:28
}
)
data_for_writing = {
"experiments": results,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: why not call these results?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When reading a data file, I find it more clear to see "experiments" and "system_metadata". But in the code, I think "results" is more clear that it's the return value of running the experiments.

@scotts scotts merged commit fd4c288 into meta-pytorch:main Nov 20, 2024
37 of 38 checks passed
@scotts scotts deleted the system_stamp branch November 20, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants