Skip to content

Conversation

@ahmadsharif1
Copy link
Contributor

  1. Set ffmpeg thread count to 0 for single video benchmarks. This should saturate the system.
  2. Set ffmpeg thread count to 1 for concurrent benchmarks. This should saturate the system because we have concurrency at the layer above the decoder.
  3. Call concurrent benchmarks "concurrent" instead of "dataloader" as they don't technically use the pytorch dataloader.
  4. Print the benchmark that's about to be run on the screen. This is only about 10 lines of output and makes it clear which benchmark takes a long time to finish.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 20, 2024
@ahmadsharif1 ahmadsharif1 marked this pull request as ready for review November 21, 2024 19:41
@ahmadsharif1 ahmadsharif1 merged commit 7e2da5d into meta-pytorch:main Nov 21, 2024
22 checks passed
@ahmadsharif1 ahmadsharif1 deleted the bench10 branch November 21, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants