Simpler experiment names #411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
scotts
commented
Nov 24, 2024
scotts
commented
- Simplifies experiment names, naming them more after what they do rather than how they do it.
- Renames the actual methods to match.
- Unifies where those names come from. (Except for the concurrency experiment, which is already a special case.)
- Moves the stamp to the bottom left. It's overlapping with text in the upper left.
facebook-github-bot
added
the
CLA Signed
ahmadsharif1
approved these changes
Nov 25, 2024
Contributor
ahmadsharif1
left a comment
ahmadsharif1
left a comment
There was a problem hiding this comment.
IMO "decode" feels a bit more explicit/accurate compared to "sample"
Contributor
Author
|
@ahmadsharif1, sure let's go with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.