Improve/fix test assertion #417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
NicolasHug
commented
Dec 2, 2024
Comment on lines
+440
to
+445
| torch.testing.assert_close( | ||
| clip_1.pts_seconds, clip_2.pts_seconds, rtol=0, atol=0 | ||
| ) | ||
| torch.testing.assert_close( | ||
| clip_1.duration_seconds, clip_2.duration_seconds, rtol=0, atol=0 | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
This is an example of the kind of assertions that were way too loose.
scotts
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main thing this PR fixes is the fact that we were calling
assert_tensor_equalwhen checking pts or duration values. That was wrong. The reason it was wrong is thatassert_tensor_equalallows foratol=2oratol=3on CUDA or MACOS. Callingassert_tensor_equalfor checking against a PTS thus means "assert the pts is this value, plu or minus 3 seconds". That's waaaay too loose. This PR changes those checks to something stricter, and renamesassert_tensor_equalintoassert_frames_equalso that we know to only call that with frames.Detailed changes:
assert_tensor_equalintoassert_frames_equaltorch.testing.assert_close(...)assert_tensor_closeand replace its usage (5-6 cases only, and located in a single function only) with plaintorch.testing.assert_close(...).