Skip to content

Conversation

@scotts
Copy link
Contributor

@scotts scotts commented Feb 26, 2025

This PR does three things:

  1. Removes a torch.compile test from ops that used a very basic version of what would eventually become VideoDecoder in Python. Also removes that basic class.
  2. Implements a new test using the actual VideoDecoder. We get a graph break, which we can avoid by setting a flag. I think it's worth keeping this test around for now to know if we get more. I think this will eventually become a priority.
  3. The compilation test revealed that we missed removing stream_index from our abstraction functions when we removed them from the API implementations.

@scotts scotts marked this pull request as ready for review February 26, 2025 16:30
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Feb 26, 2025
@scotts scotts merged commit 492a6bc into meta-pytorch:main Feb 26, 2025
47 checks passed
@scotts scotts deleted the test_cleanup branch February 26, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants