Add AudioDecoder docs and tutorial #582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
NicolasHug
commented
Mar 21, 2025
|
|
||
| duration_seconds = samples.data.shape[1] / samples.sample_rate | ||
| print(f"Duration = {int(duration_seconds // 60)}m{int(duration_seconds % 60)}s.") | ||
|
|
Contributor
Author
There was a problem hiding this comment.
As I'm writing this, I feel like we should just set the duration_seconds field ourselves and make it part of AudioSamples? It's not like memory is a problem, and it would be consistent with video frames.
Contributor
There was a problem hiding this comment.
Yes, I think it would be useful. I was wondering the same thing when reading the tutorial.
scotts
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds most docs for audio decoding, but more will come (like the metadata rendering stuff). This PR needs both #584 and #586 to be merged first.
Docs currently look like this: