Skip to content

Conversation

@scotts
Copy link
Contributor

@scotts scotts commented Apr 2, 2025

These are already included in FFMPEGCommon.h; I think it's reasonable that we assume all .cpp files that need to do FFmpeg stuff have included FFMPEGCommon.h either directly or indirectly. Better for clarity and build times.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Apr 2, 2025
@scotts scotts marked this pull request as ready for review April 2, 2025 16:08
@scotts scotts requested a review from NicolasHug April 2, 2025 16:08
@scotts scotts merged commit 4b572e8 into meta-pytorch:main Apr 2, 2025
46 checks passed
@scotts scotts deleted the prune_dupe_includes branch April 2, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants