Encoding: support wav, flac etc. #630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
NicolasHug
commented
Apr 9, 2025
| avCodecContext_->sample_rate = sampleRate; | ||
|
|
||
| // Note: This is the format of the **input** waveform. This doesn't determine | ||
| // the output. |
Contributor
Author
There was a problem hiding this comment.
My original comment was wrong: that's not the format of the input waveform. It's the format of the input AVFrame that we pass to avcodec_send_frame(). And it needs to be a format that the codec supports.
NicolasHug
commented
Apr 9, 2025
| avCodecContext_->frame_size > 0, | ||
| "frame_size is ", | ||
| avCodecContext_->frame_size, | ||
| ". Cannot encode. This should probably never happen?"); |
Contributor
Author
There was a problem hiding this comment.
This won't always be non-zero, see below.
Contributor
There was a problem hiding this comment.
Interesting - it might be worth noting why from the docs (https://ffmpeg.org/doxygen/6.0/structAVCodecContext.html#aec57f0d859a6df8b479cd93ca3a44a33, which I admit to not understanding) when we turn 0 into our default.
NicolasHug
commented
Apr 11, 2025
NicolasHug
commented
Apr 11, 2025
| # Check that decode(encode(samples)) == samples on lossless formats | ||
|
|
||
| if get_ffmpeg_major_version() == 4 and output_format == "wav": | ||
| pytest.skip("Swresample with FFmpeg 4 doesn't work on wav files") |
Contributor
Author
There was a problem hiding this comment.
scotts
reviewed
Apr 11, 2025
scotts
reviewed
Apr 11, 2025
scotts
reviewed
Apr 11, 2025
scotts
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for encoding formats where the encoder doesn't natively support FLTP, which is the sample format of the input waveform. We use
swresampleto convert the input FLTP AVFrames into a sample format that the encoder support.