Skip to content

Conversation

NicolasHug
Copy link
Contributor

@NicolasHug NicolasHug commented Jul 4, 2025

This PR adds Windows builds for our non-GPL FFmpeg binaries that we will then upload to S3.

This is passing, see e.g. https://github.com/pytorch/torchcodec/actions/runs/16081032115/job/45385732283?pr=752

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jul 4, 2025
@NicolasHug NicolasHug marked this pull request as ready for review July 4, 2025 21:36
Copy link
Contributor

@scotts scotts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see we're actually invoking the same build scrip that Linux and Mac use - which is excellent - but we're doing a bunch of setup before that. Any insight into what that's is doing?

@NicolasHug
Copy link
Contributor Author

My understanding of vc_env_helper.bat is that it's a generic helper to sett up the right configuration for the windows compiler. The script takes a command as input, e.g. our ffmpeg build script or whatever else like pip install -e ., and executes that command with the right environment. I don't have much more insight into it, there's a very similar helper in torchvision, so I was comfortable copy/pasting it blindly: https://github.com/pytorch/vision/blob/main/packaging/windows/internal/vc_env_helper.bat

An I think packaging/build_ffmpeg.bat does more of the same thing, i.e. setting up the env correctly, specifically for the FFmpeg build this time.

@NicolasHug NicolasHug merged commit 7d1c791 into meta-pytorch:main Jul 7, 2025
49 of 53 checks passed
Dan-Flores pushed a commit to Dan-Flores/torchcodec that referenced this pull request Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants