Move pybind out of ncclx #68
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Follow the same naming pattern as other cpp files under torchcomms. Use *.cpp instead of *.cc Differential Revision: D87873629 Reviewed By: siyengar
meta-cla
bot
added
the
CLA Signed
Summary: Pull Request resolved: meta-pytorch#68 D85694262 added transport pybind layer at ncclx which is not approriate. They are very different libs. It introduce third party library and make internal conda image fail. Move it to RdmaTransport lib folder. Reviewed By: d4l3k Differential Revision: D87873651
tanquer
force-pushed
the
export-D87873651
branch
from
11c0a6d to
7ea54cb
Compare
|
This pull request has been merged in 8ef1259. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: D85694262 added transport pybind layer at ncclx which is not approriate. They are very different libs. It introduce third party library and make internal conda image fail. Move it to RdmaTransport lib folder.
Differential Revision: D87873651