Skip to content

CollTrace Scuba Logging for Dashboard #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

CollTrace Scuba Logging for Dashboard #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions comms/utils/logger/ScubaLogger.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,13 @@ void NcclScubaEvent::record() {
ncclLogToScuba(type_, copySample);
}

void NcclScubaEvent::record(const std::string& stage) {
if (!stage.empty()) {
sample_.addNormal("stage", stage);
}
record();
}

void NcclScubaEvent::setLogMetatData(const CommLogData* logMetaData) {
sample_.setCommunicatorMetadata(logMetaData);
}
Expand Down
5 changes: 2 additions & 3 deletions comms/utils/logger/ScubaLogger.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@
#include "comms/utils/logger/EventMgr.h"
#include "comms/utils/logger/NcclScubaSample.h"

class NcclScubaEvent {
public:
struct NcclScubaEvent {
void startAndRecord();
void stopAndRecord();
void lapAndRecord(const std::string& stage = "");
void record();
void record(const std::string& stage);
void setLogMetatData(const CommLogData* logMetaData);

explicit NcclScubaEvent(const std::string& stage);
Expand All @@ -26,7 +26,6 @@ class NcclScubaEvent {

NcclScubaEvent(const std::string& stage, const CommLogData* logMetaData);

private:
NcclScubaSample sample_;
folly::stop_watch<std::chrono::microseconds> timer_;
std::string stage_{};
Expand Down
Loading