Introduce a temporary Service implementation that isn't an Actor #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
joecummings
approved these changes
Sep 1, 2025
allenwang28
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monarch doesn't support nested actors well yet, i.e. an actor that itself spins up processes and spawns actors on those processes. It will eventually support this, needs
ProcMeshReflanded, which is actively being developed. As is, these nested actors aren't able to communicate with each other which is why we were seeing errors in torchstore.This PR introduces a Service implementation that isn't based on an Actor, while retaining the exact same APIs. It's basically the same Service code as before, just removing the endpoints/calls/spawning a service actor etc.
The plan for this will be to remove the current implementation in favor of what we're calling "V2" whenever ProcMeshRef is well supported.