-
Notifications
You must be signed in to change notification settings - Fork 17
Skip tests when there are import issues on CI worker #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Maybe we can use |
I think we should explicitly mark these tests as not tested by CI and try to fix CI and migrate these no-CI tests after, instead of burying it. Adding an automatic pytest skip further complicates it as the test may or may not have been run, and the only way to know is to dig in the logs. For example, if we do introduce a genuine import error in the future, then whole test will be skipped (even locally) , which we probably don't want. |
sure we can explicitly mark these tests as skipped. IMO the right way to do this is with pytest with like |
If you say so. Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @casteryh, we should remove this once the pip install paths are working!
No description provided.