[Cleanup] [Policy] Use EngineArgs directly instead of custom class
#381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
joecummings
force-pushed
the
whoops-v2
branch
from
dc439c4 to
e45957c
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #381 +/- ##
=======================================
Coverage ? 64.49%
=======================================
Files ? 79
Lines ? 7709
Branches ? 0
=======================================
Hits ? 4972
Misses ? 2737
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Jack-Khuu
approved these changes
Oct 10, 2025
| if isinstance(engine_config, Mapping): | ||
| engine_config = EngineConfig.from_dict(engine_config) | ||
| if isinstance(engine_args, Mapping): | ||
| engine_args = EngineArgs(**engine_args) |
There was a problem hiding this comment.
Same flag as the other PR, when folks want to use the richer nested fields in EngineArgs we'll need to support it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We previously had a custom class called
EngineConfigthat would selectively map variables to vLLM'sEngineArgs. While this was nice for conversion to/fro dictionary structs, it was an additional redirect for the user to understand what knobs were actually available for creating the vLLM engine.Changes
EngineConfig, instead relying directly onEngineArgs.EngineArgsTesting