Remove HostMesh v0 APIs #406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
vidhyav
reviewed
Oct 14, 2025
scripts/install.sh
Outdated
Comment on lines
312
to
314
| # Temporary measure until this environment variable is removed | ||
| export MONARCH_HOST_MESH_V1_REMOVE_ME_BEFORE_RELEASE=1 | ||
There was a problem hiding this comment.
Is it possible to stage this in two PRs?
First, move to v1 as default and then remove all the v0 code as another PR? Can help us easily revert if needed in the future.
vidhyav
approved these changes
Oct 14, 2025
| ) | ||
|
|
||
| MONARCH_HOSTMESH_V1 = EnvVar( | ||
| name="MONARCH_HOST_MESH_V1_REMOVE_ME_BEFORE_RELEASE", |
vidhyav
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested this locally and on SLURM. The monarch hostmesh piece will be automatically set in the install script for now so users don't have to do this.