Metric Logging updates 6/N - Enable SFT metrics / del old #490
+373
−1,921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… file" (meta-pytorch#489) This reverts commit c2049fc.
meta-cla
bot
added
the
CLA Signed
added 2 commits
October 22, 2025 09:56
felipemello1
changed the title
ebsmothers
approved these changes
Oct 22, 2025
photomz
pushed a commit
to photomz/forge
that referenced
this pull request
Oct 25, 2025
…ch#490) Co-authored-by: Felipe Mello <felipemello@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
revert of the revert of #396
There was a flaky test. Things passed locally, but CI seems to have race condition on /tmp folder created for distributed testing. I added a fix to the unit test. I reran CI twice. We should be good.