Metric logger #554
Merged
Metric logger #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 10, 2025 20:59
- Fixes AttributeError when calling get_or_create_metric_logger() in actors - Use get_or_spawn_controller() to get reference to global logger - Avoids this_proc() call that returns ProcMeshRef instead of ProcMesh - Enables WandB metric flushing from distributed training actors - Loss values now appear in WandB dashboard across all ranks
meta-cla
bot
added
the
CLA Signed
felipemello1
approved these changes
Nov 11, 2025
felipemello1
added a commit
that referenced
this pull request
Nov 11, 2025
This reverts commit a642464.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing this issue here: #553
Problem
get_or_create_metric_logger()inside actors fails with:AttributeError: NYI: attempting to get ProcMesh attribute 'slice' on object that's actually a ProcMeshRefthis_proc()returnsProcMeshRef(proxy) instead ofProcMesh(actual mesh) in actor contextsSolution
get_or_spawn_controller("global_logger", GlobalLoggingActor)to get reference to the existing global loggerthis_proc()which fails in actor contextsChanges
setup_metric_logger()to useget_or_spawn_controller()instead ofget_or_create_metric_logger()GlobalLoggingActorandget_or_spawn_controller