Bug fix for dropping episodes in the GRPO #601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@daniellepintz has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87554570. |
Summary: ## Bug Description: meta-pytorch#580 had incorrect indentation cuasing the input_ids, episodes varibles to be deleted inside the episodes building loop, causing program to hang. Next diff shall make background thread crashes to be surfaced to the main thread so that we know what thread crashed for what reason. Reviewed By: daniellepintz Differential Revision: D87554570
daniellepintz
force-pushed
the
export-D87554570
branch
from
8546ee4 to
f8219b9
Compare
JenniferWang
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Bug Description:
#580 had incorrect indentation
cuasing the input_ids, episodes varibles to be deleted inside the episodes
building loop, causing program to hang.
Next diff shall make background thread crashes to be surfaced to the main thread so that we know what thread crashed for what reason.
Reviewed By: daniellepintz
Differential Revision: D87554570