Allow passing in custom sampler in ReplayBuffer #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 28, 2025
Closed
meta-cla
bot
added
the
CLA Signed
Summary: Added `BufferView` and `RawBuffer` interface. A sampler will operate on a BufferView and return the sampled keys. A ReplayBuffer will own a RawBuffer and operate on that. Test Plan: n/a
Summary: Implement SimpleRawBuffer, a RawBuffer backed by a python dict. Test Plan: unit tests
Summary: This diff adds a new interface called `StatefulSampler` and implements a new class called `RandomStatefulSampler`. The `RandomStatefulSampler` class is a stateful sampler that uses Python's `random.sample` function for deterministic sampling. Test Plan: unit tests
casteryh
commented
Aug 28, 2025
|
|
||
| @pytest.mark.asyncio | ||
| async def test_setup_accepts_sampler(self, mocker) -> None: | ||
| # This test is flaky and only works if it is run on a single machine. |
There was a problem hiding this comment.
@allenwang28 Is there a supported way to test monarch actors?
Summary: This diff allows passing in a custom sampler in the ReplayBuffer class. The changes include adding a new sampler class and modifying the ReplayBuffer class to accept a sampler as a parameter. The code changes also include modifying the test_replay_buffer.py file to test the new sampler functionality. Test Plan: unit tests (flaky)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff allows passing in a custom sampler in the ReplayBuffer class. The changes include adding a new sampler class and modifying the ReplayBuffer class to accept a sampler as a parameter. The code changes also include modifying the test_replay_buffer.py file to test the new sampler functionality.
Test Plan:
unit tests (flaky)
Stack created with Sapling. Best reviewed with ReviewStack.