add NJT/TD support in test data generator #2528
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65120889 |
TroyGarden
added a commit
to TroyGarden/torchrec
that referenced
this pull request
Oct 30, 2024
Summary: # context * add NJT/TD support in test data generator * add NJT/TD input option in pipeline benchmark * resolve pyre/typing errors in multiple places * should be safe to land, no production impact NOTE: This diff is splitted from the next one (D65103519) to resolve pyre/typing errors Differential Revision: D65120889
TroyGarden
force-pushed
the
export-D65120889
branch
from
06396c5 to
ffe02f8
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65120889 |
TroyGarden
added a commit
to TroyGarden/torchrec
that referenced
this pull request
Oct 30, 2024
Summary: # context * add NJT/TD support in test data generator * add NJT/TD input option in pipeline benchmark * resolve pyre/typing errors in multiple places * should be safe to land, no production impact NOTE: This diff is splitted from the next one (D65103519) to resolve pyre/typing errors Differential Revision: D65120889
TroyGarden
force-pushed
the
export-D65120889
branch
from
ffe02f8 to
f6b9c0b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65120889 |
TroyGarden
force-pushed
the
export-D65120889
branch
from
f6b9c0b to
5014b51
Compare
TroyGarden
added a commit
to TroyGarden/torchrec
that referenced
this pull request
Nov 15, 2024
Summary: # context * add NJT/TD support in test data generator * add NJT/TD input option in pipeline benchmark * resolve pyre/typing errors in multiple places * should be safe to land, no production impact NOTE: This diff is splitted from the next one (D65103519) to resolve pyre/typing errors Differential Revision: D65120889
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65120889 |
TroyGarden
force-pushed
the
export-D65120889
branch
from
5014b51 to
3a62823
Compare
TroyGarden
added a commit
to TroyGarden/torchrec
that referenced
this pull request
Nov 18, 2024
Summary: # context * add NJT/TD support in test data generator * add NJT/TD input option in pipeline benchmark * resolve pyre/typing errors in multiple places * should be safe to land, no production impact NOTE: This diff is splitted from the next one (D65103519) to resolve pyre/typing errors Reviewed By: dstaay-fb Differential Revision: D65120889
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65120889 |
Summary: # context * add NJT/TD support in test data generator * add NJT/TD input option in pipeline benchmark * resolve pyre/typing errors in multiple places * should be safe to land, no production impact NOTE: This diff is splitted from the next one (D65103519) to resolve pyre/typing errors Reviewed By: dstaay-fb Differential Revision: D65120889
TroyGarden
force-pushed
the
export-D65120889
branch
from
3a62823 to
165c2d1
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D65120889 |
PaulZhang12
added a commit
that referenced
this pull request
Jan 23, 2025
This reverts commit e35119d.
PaulZhang12
added a commit
that referenced
this pull request
Jan 23, 2025
This reverts commit e5e2565.
PaulZhang12
added a commit
that referenced
this pull request
Jan 24, 2025
)""" This reverts commit 3441ac3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
context
NOTE: This diff is splitted from the next one (D65103519) to resolve pyre/typing errors
Differential Revision: D65120889