Updating record_lookup function signature to accommodate future implementations #3471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
aliafzal
force-pushed
the
export-D80614980
branch
from
daf21c2 to
6fee14f
Compare
aliafzal
added a commit
to aliafzal/torchrec
that referenced
this pull request
Oct 21, 2025
…mentations (meta-pytorch#3471) Summary: internal General Context: We are in the process of transition to a unified DeltaTracker and this is 4/n diffs representing changes towards the transition. Specific Context: Update record_lookup function signature to accommodate MRS DeltaTracker implementation Differential Revision: D80614980
aliafzal
added a commit
to aliafzal/torchrec
that referenced
this pull request
Oct 21, 2025
…mentations (meta-pytorch#3471) Summary: internal General Context: We are in the process of transition to a unified DeltaTracker and this is 4/n diffs representing changes towards the transition. Specific Context: Update record_lookup function signature to accommodate MRS DeltaTracker implementation Differential Revision: D80614980
aliafzal
force-pushed
the
export-D80614980
branch
from
6fee14f to
795f424
Compare
…meta-pytorch#3143) Summary: X-link: meta-pytorch#3143 ### Overview This diff adds support for tracking optimizer states in the Model Delta Tracker system. It introduces a new tracking mode called `MOMENTUM_LAST` that enables tracking of momentum values from optimizers to support approximate top-k delta-row selection. ### Key Changes #### 1. Optimizer State Tracking Support * To support tracking of optimizer states I have added `optim_state_tracker_fn` attribute to `GroupedEmbeddingsLookup` and `GroupedPooledEmbeddingsLookup` classes responsible for traversing over the BatchedFused modules. * Implemented `register_optim_state_tracker_fn()` method in both classes to register the trackable callable * Tracking calls are invoked after each lookup operation. #### 2. Model Delta Tracker Changes * Added `record_momentum()` method to track momentum values from optimizer states and its support in record_lookup function. * Added validation and optim tracker function logic to support the new `MOMENTUM_LAST` mode #### 3. New Tracking Mode * Added `TrackingMode.MOMENTUM_LAST` to [`**types.py**`](command:code-compose.open?%5B%22%2Ffbcode%2Ftorchrec%2Fdistributed%2Fmodel_tracker%2Ftypes.py%22%2Cnull%5D "/fbcode/torchrec/distributed/model_tracker/types.py") * Maps to `EmbdUpdateMode.LAST` to capture the most recent momentum values Differential Revision: D76868111
…meta-pytorch#3144) Summary: X-link: meta-pytorch#3144 This diff extends the Model Delta Tracker to support two new tracking modes: `MOMENTUM_DIFF` and `ROWWISE_ADAGRAD`, which enable tracking of rowwise optimizer states for more sophisticated gradient analysis. Differential Revision: D76918891
Summary: Make DeltaStore generic to allow use case specific custom implementations internal General Context: We are in the process of transition to a unified DeltaTracker and this is 1/n diffs representing changes towards the transition. Specific Context: DeltaTracker utilizes Memstore to preserve and compact lookups extracted during embedding lookups. As part of transitioning to a common DeltaTracker, we are adding a generic DeltaStore. Memstore will extend from Generic DeltaStore, allowing both MRS and OSS DeltaTrackers to be easily integrated into training frameworks. Differential Revision: D80614364
Summary: internal General Context: We are in the process of transition to a unified DeltaTracker and this is 2/n diffs representing changes towards the transition. Specific Context: Update DeltaStore APIs to match Memstore APIs for backward compatibility. Differential Revision: D80614586
Summary: Make ModelDeltaTracker generic to allow use case specific custom implementations internal General Context: We are in the process of transition to a unified DeltaTracker and this is 3/n diffs representing changes towards the transition. Specific Context: DeltaTracker implements primitives to allow tracking of embedding ids and states to optimize checkpointing and embedding freshness. As part of transitioning to a common DeltaTracker, we are adding a generic ModelDeltaTracker. MRS DeltaTracker will extend from Generic ModelDeltaTracker. Differential Revision: D80614689
…mentations (meta-pytorch#3471) Summary: internal General Context: We are in the process of transition to a unified DeltaTracker and this is 4/n diffs representing changes towards the transition. Specific Context: Update record_lookup function signature to accommodate MRS DeltaTracker implementation Differential Revision: D80614980
aliafzal
force-pushed
the
export-D80614980
branch
from
795f424 to
94e1849
Compare
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
internal
General Context: We are in the process of transition to a unified DeltaTracker and this is 4/n diffs representing changes towards the transition.
Specific Context: Update record_lookup function signature to accommodate MRS DeltaTracker implementation
Differential Revision: D80614980