Skip to content

Removing unused tests #3555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Removing unused tests #3555

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 0 additions & 37 deletions torchrec/modules/tests/test_feature_processor_.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,23 +61,6 @@ def test_populate_weights(self) -> None:
weighted_features.lengths(), weighted_features_gm_script.lengths()
)

# TODO: this test is not being run
# pyre-ignore
@unittest.skipIf(
torch.cuda.device_count() <= 0,
"Not enough GPUs, this test requires at least one GPU",
)
def test_rematerialize_from_meta(self) -> None:
pw = PositionWeightedModule(max_feature_length=10, device=torch.device("meta"))
self.assertTrue(pw.position_weight.is_meta)

# Re-materialize on cuda
init_parameters(pw, torch.device("cuda"))
self.assertTrue(not pw.position_weight.is_meta)
torch.testing.assert_close(
pw.position_weight, torch.ones_like(pw.position_weight)
)


class PositionWeightedCollectionModuleTest(unittest.TestCase):
def test_populate_weights(self) -> None:
Expand Down Expand Up @@ -133,26 +116,6 @@ def test_populate_weights(self) -> None:
empty_fp_kjt.length_per_key(), empty_fp_kjt_gm_script.length_per_key()
)

# TODO: this test is not being run
# pyre-ignore
@unittest.skipIf(
torch.cuda.device_count() <= 0,
"Not enough GPUs, this test requires at least one GPU",
)
def test_rematerialize_from_meta(self) -> None:
pwmc = PositionWeightedModuleCollection(
max_feature_lengths={"f1": 10, "f2": 10},
device=torch.device("meta"),
)
self.assertTrue(all(param.is_meta for param in pwmc.position_weights.values()))

# Re-materialize on cuda
init_parameters(pwmc, torch.device("cuda"))
for key, param in pwmc.position_weights.items():
self.assertTrue(not param.is_meta)
self.assertTrue(pwmc.position_weights_dict[key] is param)
torch.testing.assert_close(param, torch.ones_like(param))

# pyre-ignore
@unittest.skipIf(
torch.cuda.device_count() <= 0,
Expand Down
Loading