Skip to content

Thread PG: add class _World to distributed_c10d.py (#86348) #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Thread PG: add class _World to distributed_c10d.py (#86348) #781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion examples/retrieval/two_tower_train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,11 @@ def train(
compute_device=device.type,
),
).collective_plan(
module=two_tower_model, sharders=sharders, pg=dist.GroupMember.WORLD
module=two_tower_model,
sharders=sharders,
# pyre-fixme[6]: For 3rd param expected `ProcessGroup` but got
# `Optional[ProcessGroup]`.
pg=dist.GroupMember.WORLD,
)
model = DistributedModelParallel(
module=two_tower_train_task,
Expand Down
2 changes: 2 additions & 0 deletions torchrec/distributed/tests/test_model_parallel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -732,6 +732,8 @@ def reset_parameters(self) -> None:
)

def test_meta_device_dmp_state_dict(self) -> None:
# pyre-fixme[6]: For 1st param expected `ProcessGroup` but got
# `Optional[ProcessGroup]`.
env = ShardingEnv.from_process_group(dist.GroupMember.WORLD)

m1 = TestSparseNN(
Expand Down